Skip to content

Conversation

@kubermatic-bot
Copy link
Contributor

@kubermatic-bot kubermatic-bot commented Mar 9, 2022

This is an automated cherry-pick of #1200 and #1190

/assign moadqassem

NONE

Signed-off-by: Helene Durand <helene@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2022
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@kubermatic-bot kubermatic-bot added the sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. label Mar 10, 2022
@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kubermatic-bot
To complete the pull request process, please ask for approval from moadqassem after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moadqassem
Copy link
Member

/test pull-machine-controller-e2e-deployment-upgrade

1 similar comment
@moadqassem
Copy link
Member

/test pull-machine-controller-e2e-deployment-upgrade

@moadqassem
Copy link
Member

/retest

3 similar comments
@moadqassem
Copy link
Member

/retest

@moadqassem
Copy link
Member

/retest

@moadqassem
Copy link
Member

/retest

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
(cherry picked from commit e35da15)
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2022
@moadqassem
Copy link
Member

/retest

@moadqassem moadqassem requested a review from xrstf March 15, 2022 16:10
@moadqassem moadqassem merged commit e7f22be into kubermatic:release/v1.42 Mar 15, 2022
@xrstf
Copy link
Contributor

xrstf commented Mar 15, 2022

Did you skip waiting for the review?

moadqassem added a commit that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants