[release/v1.36] Waiting for volumeAttachments deletion (#1190) #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Waiting for volumeAttachments deletion Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * volumeAttachments check only for vSphere Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * ClusterRole updated Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * yaml linter fixed Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * VolumeAttachments correctly handled Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * Code factorized Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * renaming Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * fix yamllint Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * Logic applied only to vSphere Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> (cherry picked from commit e35da15)
kubermatic-bot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadqassem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
sig/cluster-management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cherry pick volume de/attach in vSphere external csi driver fix
Which issue(s) this PR fixes (optional, in
fixes #<issue number>format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Optional Release Note: