Skip to content

add support for rhel 9 for Azure provider #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

add support for rhel 9 for Azure provider #1963

merged 1 commit into from
Sep 16, 2025

Conversation

@rajaSahil
Copy link
Contributor

What this PR does / why we need it:
Add support for rhel 9 for Azure provider.

Which issue(s) this PR fixes:

Fixes #1660

What type of PR is this?

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add support for rhel 9 for Azure provider.

Documentation:

None

@rajaSahil
add support for rhel 9
5e2c75b 
Signed-off-by: rajaSahil <sahilraja242@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2025
@rajaSahil
Copy link
Contributor Author

/assign @kron4eg

kron4eg
kron4eg reviewed Sep 15, 2025
View reviewed changes
pkg/cloudprovider/provider/azure/provider.go
},
providerconfig.OperatingSystemRHEL: {
Publisher: to.StringPtr("RedHat"),
Offer: to.StringPtr("rhel-byos"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we try to use official azure RHEL images?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use a different image, they need to provide the image ID, that’s the current behaviour we support as well.

@kron4eg
Copy link
Member

kron4eg commented Sep 16, 2025

/retest

@kron4eg
Copy link
Member

kron4eg commented Sep 16, 2025

looks like it doesn't work 🤷

@rajaSahil
Copy link
Contributor Author

rajaSahil commented Sep 16, 2025 •
edited
Loading

This will not work until the OSM PR kubermatic/operating-system-manager#511 is merged.

@rajaSahil
Copy link
Contributor Author

/retest

@kron4eg
Copy link
Member

kron4eg commented Sep 16, 2025

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a7b1e77fafef82433978d9c138a591f65125c11

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2025
@kubermatic-bot kubermatic-bot merged commit 3e25421 into kubermatic:main Sep 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kron4eg kron4eg kron4eg left review comments

Assignees

@kron4eg kron4eg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support RHEL 9 as OS

3 participants

@rajaSahil @kron4eg @kubermatic-bot