Skip to content

fix nil pointer exception during OpenStack FloatingIP assignment #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2018
Merged

fix nil pointer exception during OpenStack FloatingIP assignment #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/cloudprovider/provider/openstack/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,12 @@ func assignFloatingIPToInstance(client *gophercloud.ProviderClient, instanceID,
return osErrorToTerminalError(err, "failed to allocate a floating ip")
}
} else {
ip, err = osfloatingips.Update(netClient, freeFloatingIps[0].ID, osfloatingips.UpdateOpts{
freeIP := freeFloatingIps[0]
ip, err := osfloatingips.Update(netClient, freeIP.ID, osfloatingips.UpdateOpts{
PortID: &port.ID,
}).Extract()
if err != nil {
return fmt.Errorf("failed to update FloatingIP %s: %v", ip.ID, err)
return fmt.Errorf("failed to update FloatingIP %s(%s): %v", freeIP.ID, freeIP.FloatingIP, err)
}

// We're now going to wait 3 seconds and check if the IP is still ours. If not, we're going to fail
Expand Down