Add .NET 10 target framework support #1686
Merged
+57
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>
k8s-ci-robot
added
size/S
Copilot
AI
changed the title
[WIP] Add support for .net10 target
Add .NET 10 target framework support
Nov 18, 2025
Copilot finished work on behalf of
tg123
November 18, 2025 02:42
Member
|
@copilot could you please rebase with master |
…oseconds (#1687) * Initial plan * Fix datetime serialization to always output 6 decimal places for fractional seconds Co-authored-by: tg123 <170430+tg123@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>
k8s-ci-robot
added
size/M
Contributor
Author
Copilot finished work on behalf of
tg123
November 18, 2025 17:24
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Copilot, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Copilot finished reviewing on behalf of
tg123
November 19, 2025 02:48
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds .NET 10 target framework support to the Kubernetes C# client library. The changes are minimal and surgical, adding net10.0 to existing multi-targeting configurations without modifying core functionality. Additionally, the PR includes a bug fix for DateTime serialization to ensure RFC3339Micro format compliance with the Kubernetes API.
Key Changes
- Added
net10.0target framework to all source and test projects - Updated CI/CD workflows to install and use .NET 10 SDK
- Fixed DateTime serialization to always output exactly 6 decimal places for fractional seconds (RFC3339Micro format requirement)
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/KubernetesClient/KubernetesClient.csproj | Added net10.0 to target frameworks |
| src/KubernetesClient.Aot/KubernetesClient.Aot.csproj | Added net10.0 to target frameworks |
| src/KubernetesClient.Kubectl/KubernetesClient.Kubectl.csproj | Added net10.0 to target frameworks |
| src/KubernetesClient/KubernetesJson.cs | Fixed DateTime serialization to ensure 6-digit fractional seconds for RFC3339Micro format |
| tests/KubernetesClient.Tests/KubernetesClient.Tests.csproj | Added net10.0 to target frameworks |
| tests/KubernetesClient.Classic.Tests/KubernetesClient.Classic.Tests.csproj | Added net10.0 to target frameworks for both Windows and non-Windows builds |
| tests/Kubectl.Tests/Kubectl.Tests.csproj | Added net10.0 to target frameworks |
| tests/E2E.Tests/E2E.Tests.csproj | Added net10.0 to target frameworks |
| tests/KubernetesClient.Tests/KubernetesJsonTests.cs | Added test to validate 6-digit fractional seconds requirement |
| .github/workflows/buildtest.yaml | Added 10.0.x SDK to build, test, and E2E jobs; updated MSBuild codegen job to use 10.0.x |
| .github/workflows/nuget.yaml | Added 10.0.x SDK to NuGet packaging workflow |
| .github/workflows/draft.yaml | Added 10.0.x SDK to draft release workflow |
| .github/workflows/docfx.yaml | Added 10.0.x SDK to documentation generation workflow |
| .github/workflows/codeql-analysis.yml | Added 10.0.x SDK to CodeQL security analysis workflow |
| README.md | Updated version compatibility table to include net10.0 for SDK version 18.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot AI
added a commit
that referenced
this pull request
Nov 19, 2025
* Initial plan * Add .NET 10 support to all projects and workflows Co-authored-by: tg123 <170430+tg123@users.noreply.github.com> * Fix datetime serialization to always output 6 decimal places for microseconds (#1687) * Initial plan * Fix datetime serialization to always output 6 decimal places for fractional seconds Co-authored-by: tg123 <170430+tg123@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tg123 <170430+tg123@users.noreply.github.com> * Initial plan --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .NET 10 Support - Rebased on Master ✅
Successfully added .NET 10 target framework support to the kubernetes-client/csharp repository and rebased on the latest master branch.
Changes Implemented:
Test Results:
Security Summary:
✅ CodeQL security scan completed with 0 alerts. No security vulnerabilities found in the changes.
The implementation is minimal and surgical, only adding net10.0 to the existing target frameworks without modifying any code logic. Rebased on master to incorporate latest changes.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.