-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add protocol buffer generation automation to maintain sync with upstream Kubernetes #4380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
|
/ok-to-test |
|
/lgtm |
brendandburns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, Copilot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Protocol buffer files were manually maintained and became outdated, missing fields like
resourcesinV1.PodSpecthat exist in both upstream Kubernetes proto definitions and OpenAPI-generated models.Changes
Automation Script
scripts/update-proto.sh: Generates proto files from kubernetes-client/gen, parameterized byKUBERNETES_BRANCHenvironment variableCI/CD Integration
.github/workflows/generate.yml: Added "Generate Proto" step between OpenAPI generation and patches, using same Kubernetes branch parameterDocumentation
proto/README.md: Documents automated workflow trigger and manual script usageGenerated Files
Result
Proto and OpenAPI models now maintain consistency automatically on each generation run.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
repository.sonatype.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /home/REDACTED/work/java/java/.mvn/wrapper/maven-wrapper.jar -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/java/java org.apache.maven.wrapper.MavenWrapperMain clean compile -pl proto -am(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.