Update node typings, remove 'abort-controller' and remove node 14 #1134
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
size/L
| "dependencies": { | ||
| "@types/js-yaml": "^4.0.1", | ||
| "@types/node": "^10.12.0", | ||
| "@types/node": "^20.3.1", |
There was a problem hiding this comment.
yeah, this is just the typings though so it doesn't really affect anything except compilation. Seems to be ok (aside from the fact that we'll no longer support node 14)
There was a problem hiding this comment.
fwiw, this is also what we have in the main branch, in release-1.x we didn't have dependabot turned on, so it didn't get updated for a long time, and then there were some compilation fixes that were needed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
brendandburns
added
the
lgtm
3 participants
Updating node typings added a definition for
AbortControllerandAbortSignalthis was added in node 15+.Node 14 is EOL anyway, so remove it from support.
Cleanup the code a little b/c of some differences between Abort* definitions and also ClientOptions.