Fix Knative Service YAML parsing by checking API groups #2686
Conversation
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| "@types/mock-fs": "^4.13.1", | ||
| "c8": "^10.0.0", | ||
| "eslint": "^9.18.0", | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
There are a few of these sprinkled throughout the PR.
There was a problem hiding this comment.
Looks like it didn't take the lastest main branch as a base, a rebase should be enough but I'm not sure how to control the agent. Leaving this to @brendandburns.
|
ugh! I made these fixes locally but I didn't commit them and then I deleted the codespace I'll redo this. |
|
Closing in favor of #2688 since I can't force push to this branch and I appended my fixes instead of stacking them. You'd think I knew how to use git by now... |
Fixes #2670
Revision of #2671