Fix no_proxy reset in configuration.py

[daezaa]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently, self.no_proxy is explicitly reset to None after being populated from environment variables (NO_PROXY or no_proxy). This effectively discards the loaded values and prevents no_proxy from being respected when configuring the client.

This commit removes the redundant assignment to None, ensuring that the no_proxy environment variable is preserved and proxy bypass settings are applied as expected.

Which issue(s) this PR fixes:

No issue has been opened yet. Let me know if needed.
Fixes #

Special notes for your reviewer:

• The change is small but corrects behavior that currently nullifies no_proxy support.
• Please confirm whether a regression test should be added for this.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daezaa
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: daezaa / name: Daesik Choi (59032da, 7e0a769)

[k8s-ci-robot]

Welcome @daezaa!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[afshin-deriv]

lgtm 👍

[roycaihw]

The change LGTM
This file is generated by openapi-generator. We also need to update the hotfix script to keep the patch: https://github.com/kubernetes-client/python/blob/master/scripts/insert_proxy_config.sh

[daezaa]

@roycaihw Thanks for the input. The script looks fine to me and no need changes but if it was executed on v33.1.0,

python/scripts/insert_proxy_config.sh

Lines 49 to 76 in 5f6cdb2

	if [ -z "$NO_PROXY_LINE" ]; then
	# self.no_proxy = None is not present → insert full block after self.proxy = None
	BLOCK+="${INDENT}# Load proxy from environment variables (if set)\n"
	BLOCK+="${INDENT}if os.getenv(\"HTTPS_PROXY\"): self.proxy = os.getenv(\"HTTPS_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"https_proxy\"): self.proxy = os.getenv(\"https_proxy\")\n"
	BLOCK+="${INDENT}if os.getenv(\"HTTP_PROXY\"): self.proxy = os.getenv(\"HTTP_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"http_proxy\"): self.proxy = os.getenv(\"http_proxy\")\n"
	BLOCK+="${INDENT}self.no_proxy = None\n"
	BLOCK+="${INDENT}# Load no_proxy from environment variables (if set)\n"
	BLOCK+="${INDENT}if os.getenv(\"NO_PROXY\"): self.no_proxy = os.getenv(\"NO_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"no_proxy\"): self.no_proxy = os.getenv(\"no_proxy\")"
	sed -i "${PROXY_LINE}a $BLOCK" "$CONFIG_FILE"
	echo "Inserted full proxy + no_proxy block after 'self.proxy = None'."
	else
	# self.no_proxy = None exists → insert only env logic after that
	BLOCK+="${INDENT}# Load proxy from environment variables (if set)\n"
	BLOCK+="${INDENT}if os.getenv(\"HTTPS_PROXY\"): self.proxy = os.getenv(\"HTTPS_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"https_proxy\"): self.proxy = os.getenv(\"https_proxy\")\n"
	BLOCK+="${INDENT}if os.getenv(\"HTTP_PROXY\"): self.proxy = os.getenv(\"HTTP_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"http_proxy\"): self.proxy = os.getenv(\"http_proxy\")\n"
	BLOCK+="${INDENT}# Load no_proxy from environment variables (if set)\n"
	BLOCK+="${INDENT}if os.getenv(\"NO_PROXY\"): self.no_proxy = os.getenv(\"NO_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"no_proxy\"): self.no_proxy = os.getenv(\"no_proxy\")"
	sed -i "${NO_PROXY_LINE}a $BLOCK" "$CONFIG_FILE"
	echo "Inserted environment block after 'self.no_proxy = None'."
	fi

the else block should've ran so that there would be no duplicates of self.no_proxy = None. However, somehow, if [ -z "$NO_PROXY_LINE" ]; then has ran even though there was self.no_proxy = None existed.

Nevertheless, I am revising the PR with the result of executing instert_proxy_config.sh script on v33.1.0 tag.
Please re-review