Skip to content

Conversation

@mauriciopoppe
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Replaces the command line arguments kubelet-pod-path and kubelet-csi-plugins-path with kubelet-path, also removes the PathContext enum from the FS v1beta3 protobuf and the internal server implementation

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Continues on the work that @jingxu97 did on #149

Does this PR introduce a user-facing change?:


`--kubelet-pod-path` and `--kubelet-csi-plugins-path` replaced with `--kubelet-path`, `PathContext` removed from the Filesystem v1beta3 API

/cc @jingxu97 @ddebroy

jingxu97 and others added 2 commits June 9, 2021 15:49
Instead of using pod and plugin paths, comebine them into one
kubeletPath option
@k8s-ci-robot k8s-ci-robot requested review from ddebroy and jingxu97 June 10, 2021 07:01
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 10, 2021
@mauriciopoppe
Copy link
Member Author

mauriciopoppe commented Jun 10, 2021

Results of the tests of 6c1d470

go test -v .\integrationtests\ -run TestFilesystemAPIGroup
=== RUN   TestFilesystemAPIGroup
=== RUN   TestFilesystemAPIGroup/v1beta2FilesystemTests
=== RUN   TestFilesystemAPIGroup/v1beta2FilesystemTests/PathExists_positive
=== RUN   TestFilesystemAPIGroup/v1beta2FilesystemTests/IsMount
=== RUN   TestFilesystemAPIGroup/v1beta1FilesystemTests
=== RUN   TestFilesystemAPIGroup/v1beta1FilesystemTests/PathExists_positive
=== RUN   TestFilesystemAPIGroup/v1beta1FilesystemTests/IsMount
=== RUN   TestFilesystemAPIGroup/v1alpha1FilesystemTests
=== RUN   TestFilesystemAPIGroup/v1alpha1FilesystemTests/PathExists_positive
=== RUN   TestFilesystemAPIGroup/v1alpha1FilesystemTests/IsMount
--- PASS: TestFilesystemAPIGroup (0.37s)
    --- PASS: TestFilesystemAPIGroup/v1beta2FilesystemTests (0.12s)
        --- PASS: TestFilesystemAPIGroup/v1beta2FilesystemTests/PathExists_positive (0.07s)
        --- PASS: TestFilesystemAPIGroup/v1beta2FilesystemTests/IsMount (0.06s)
    --- PASS: TestFilesystemAPIGroup/v1beta1FilesystemTests (0.12s)
        --- PASS: TestFilesystemAPIGroup/v1beta1FilesystemTests/PathExists_positive (0.07s)
        --- PASS: TestFilesystemAPIGroup/v1beta1FilesystemTests/IsMount (0.06s)
    --- PASS: TestFilesystemAPIGroup/v1alpha1FilesystemTests (0.12s)
        --- PASS: TestFilesystemAPIGroup/v1alpha1FilesystemTests/PathExists_positive (0.08s)
        --- PASS: TestFilesystemAPIGroup/v1alpha1FilesystemTests/IsMount (0.05s)
PASS
ok      github.com/kubernetes-csi/csi-proxy/integrationtests    0.707s

Copy link
Contributor

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mauriciopoppe. LGTM mod one comment about field numbers. (reposted below)

Copy link
Contributor

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mauriciopoppe. LGTM mod one comment about field numbers.


// Force remove all contents under path (if any).
bool force = 3;
bool force = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the comment here got deleted. Can we use reserved https://developers.google.com/protocol-buffers/docs/proto3#reserved here to prevent the re-numbering?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is useful if the same proto file is used across versions, because we have new protos for every version I'm not sure if this makes sense in this project

@ddebroy
Copy link
Contributor

ddebroy commented Jun 10, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit e7c1df0 into kubernetes-csi:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants