-
Notifications
You must be signed in to change notification settings - Fork 63
Combine plugin and pod paths into one KubeletPath #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine plugin and pod paths into one KubeletPath #150
Conversation
Instead of using pod and plugin paths, comebine them into one kubeletPath option
|
Results of the tests of 6c1d470 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mauriciopoppe. LGTM mod one comment about field numbers. (reposted below)
ddebroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mauriciopoppe. LGTM mod one comment about field numbers.
|
|
||
| // Force remove all contents under path (if any). | ||
| bool force = 3; | ||
| bool force = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the comment here got deleted. Can we use reserved https://developers.google.com/protocol-buffers/docs/proto3#reserved here to prevent the re-numbering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is useful if the same proto file is used across versions, because we have new protos for every version I'm not sure if this makes sense in this project
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddebroy, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Replaces the command line arguments
kubelet-pod-pathandkubelet-csi-plugins-pathwithkubelet-path, also removes thePathContextenum from the FS v1beta3 protobuf and the internal server implementationWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Continues on the work that @jingxu97 did on #149
Does this PR introduce a user-facing change?:
/cc @jingxu97 @ddebroy