Skip to content

Conversation

@xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Aug 2, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Change OWNERS_ALIASES to a symlink to release-tools/KUBERNETES_CSI_OWNERS_ALIASES
so that aliases can be recognized by CI.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Without this change, no one in kubernetes-csi-approvers can approve a PR in release-4.0 branch.

Does this PR introduce a user-facing change?:

NONE

Change OWNERS_ALIASES to a symlink to
release-tools/KUBERNETES_CSI_OWNERS_ALIASES.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 2, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2021
@xing-yang
Copy link
Collaborator Author

/assign @yuxiangqian

@xing-yang
Copy link
Collaborator Author

/assign @msau42

@msau42
Copy link
Collaborator

msau42 commented Aug 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2021
@xing-yang
Copy link
Collaborator Author

@yuxiangqian No one on kubernetes-csi-approvers can approve a PR in release-4.0 now. Can you approve this? Thanks.

@msau42 msau42 mentioned this pull request Aug 2, 2021
Copy link
Contributor

@yuxiangqian yuxiangqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang, yuxiangqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit ec37c2e into kubernetes-csi:release-4.0 Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants