-
Notifications
You must be signed in to change notification settings - Fork 20
Update alpha API to beta #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bswartz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign |
|
/lgtm |
|
I didn't expect that to go through without approval, apologies @xing-yang |
Looks like something causes me to auto-approve my own PRs. I wonder if that can be reversed. |
|
@xing-yang Any feedback/concerns you have I can address in a new PR, just let me know. |
|
@chrishenzie @bswartz no worries. I'll take a look. If I have comments, Ben can address with a followup PR. |
| scope: Namespaced | ||
| versions: | ||
| - name: v1alpha1 | ||
| - name: v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should line 8 be updated?
api-approved.kubernetes.io: https://github.com/kubernetes/enhancements/pull/2056
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Change alpha API to beta
Does this PR introduce a user-facing change?: