Skip to content

Conversation

@bswartz
Copy link
Contributor

@bswartz bswartz commented Feb 26, 2022

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Change alpha API to beta

Does this PR introduce a user-facing change?:

Renamed v1alpha1 API to v1beta1. The API is the same, but users must use the new version.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bswartz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2022
@xing-yang
Copy link
Contributor

/assign

@chrishenzie
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit a324f61 into kubernetes-csi:master Feb 28, 2022
@chrishenzie
Copy link

I didn't expect that to go through without approval, apologies @xing-yang

@bswartz
Copy link
Contributor Author

bswartz commented Feb 28, 2022

I didn't expect that to go through without approval, apologies @xing-yang

Looks like something causes me to auto-approve my own PRs. I wonder if that can be reversed.

@bswartz
Copy link
Contributor Author

bswartz commented Feb 28, 2022

@xing-yang Any feedback/concerns you have I can address in a new PR, just let me know.

@xing-yang
Copy link
Contributor

@chrishenzie @bswartz no worries. I'll take a look. If I have comments, Ben can address with a followup PR.

scope: Namespaced
versions:
- name: v1alpha1
- name: v1beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should line 8 be updated?

api-approved.kubernetes.io: https://github.com/kubernetes/enhancements/pull/2056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants