Skip to content

Conversation

@M00nF1sh
Copy link
Member

@M00nF1sh M00nF1sh commented Sep 15, 2020

  1. networking.SecurityGroupInfo wraps the information about a securityGroup.
    • we expand the raw EC2IPPermission into multiple ones, so that each one contain only a single source.(ipRange/ipV6Range/etc).
    • for each expanded EC2IPPermission, we compute a set of labels from description(treat the description as comma-separated kv pairs). also, a special raw/description label is added for the raw description.
  2. networking.SecurityGroupManager provides cached operations for securityGroups.
  3. networking.SecurityGroupReconciler will reconcile permissions for securityGroups.
  4. targetGroupBinding.NetworkingManager will manage the network settings for targetGroupBindings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M00nF1sh
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2020
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the expected number of permissions in the worst case?
This could cause a potential bottleneck.

Copy link
Member Author

@M00nF1sh M00nF1sh Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm, one securityGroup only have at most 10X permissions.
calculations like these will never be bottleneck :D (networking is)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you modify the main.go as well? if so please include it together.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the PR to modify main.go

@M00nF1sh M00nF1sh merged commit 48d7533 into kubernetes-sigs:v2_ga Sep 16, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
* add reconciler for securityGroup rules

* add networking manager for targetGroupBindings

* add sg deployer

* fix crd types

* add tags handling for securityGroup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants