⚠️ Clusterctl v1alpha3 should not upgrade to v1alpha4 #4268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
3 tasks
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test pull-cluster-api-test-release-0-3 |
k8s-ci-robot
added
the
needs-rebase
fabriziopandini
force-pushed
the
clusterctl-v1alpha3-should-not-upgrade-to-v1alpha4
branch
from
e8c8768 to
abd5fd3
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/test pull-cluster-api-test-release-0-3 |
|
/retest |
k8s-ci-robot
added
the
needs-rebase
fabriziopandini
force-pushed
the
clusterctl-v1alpha3-should-not-upgrade-to-v1alpha4
branch
from
abd5fd3 to
4c066a8
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
fabriziopandini
force-pushed
the
clusterctl-v1alpha3-should-not-upgrade-to-v1alpha4
branch
from
4c066a8 to
1f4f722
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
fabriziopandini
deleted the
clusterctl-v1alpha3-should-not-upgrade-to-v1alpha4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a backport of #4202
Cluster API v1alpha4 is introducing changes in how providers are deployed (see e.g webhooks running with manager).
As a consequence, clusterctl version v1alpha3 should not be allowed to upgrade to v1alpha3 clusters
Which issue(s) this PR fixes:
Rif #4192
/milestone v0.3.x
/hold
for #4202 to merge