Skip to content

🐛 Fix race condition in channel source #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
Apr 26, 2023
Merged

🐛 Fix race condition in channel source #2286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa49e6
Fix race condition in channel source
maxsmythe Apr 22, 2023
5ad39db
Also remove stop channel from struct
maxsmythe Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pkg/source/source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ type Channel struct {
// Source is the source channel to fetch GenericEvents
Source <-chan event.GenericEvent

// stop is to end ongoing goroutine, and close the channels
stop <-chan struct{}

// dest is the destination channels of the added event handlers
dest []chan event.GenericEvent

Expand All @@ -103,9 +100,6 @@ func (cs *Channel) Start(
return fmt.Errorf("must specify Channel.Source")
}

// set the stop channel to be the context.
cs.stop = ctx.Done()

// use default value if DestBufferSize not specified
if cs.DestBufferSize == 0 {
cs.DestBufferSize = defaultBufferSize
Expand Down