- 
                Notifications
    
You must be signed in to change notification settings  - Fork 186
 
fix(release): update quickstart guide version automatically #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): update quickstart guide version automatically #1803
Conversation
Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
          ✅ Deploy Preview for gateway-api-inference-extension ready!
 To edit notification comments on pull requests, go to your Netlify project configuration.  | 
    
| 
           Welcome @AvineshTripathi!   | 
    
| 
           Hi @AvineshTripathi. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.  | 
    
| OLD_VERSION=$(grep -oE 'export IGW_CHART_VERSION=v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?' "$GUIDES_INDEX" | head -n1 | cut -d'=' -f2) | ||
| sed -i.bak -E "s/${OLD_VERSION}/${RELEASE_TAG}/g" "$GUIDES_INDEX" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change doesn't cover all the places where the version appears.
for example - the kubectl apply commands that deploy a yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nirrozenbaum, got it are you referring to version mentions in other places (like kubectl commands in other files)? If you’ve spotted a specific case where it misses, can you point me to it?
I tested this locally with a quick hack:
GUIDES_INDEX="../site-src/guides/index.md"
OLD_VERSION=$(grep -oE 'export IGW_CHART_VERSION=v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?' "$GUIDES_INDEX" | head -n1 | cut -d'=' -f2)
echo $OLD_VERSION
sed -i.bak -E "s/${OLD_VERSION}/${RELEASE_TAG}/g" "$GUIDES_INDEX"
It correctly updated the .md file, so just want to confirm if I’m missing another place or case where this wouldn’t work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I was talking about kubectl commands. but I just verified that your fix is working as expected.
sorry, my mistake.
Thanks!
/ok-to-test
/lgtm
/approve
| 
           [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AvineshTripathi, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
      
 Approvers can indicate their approval by writing   | 
    
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1784
Does this PR introduce a user-facing change?: