-
Notifications
You must be signed in to change notification settings - Fork 195
Add AutoTune config to prefix scorer to make it explicit when auto vs. manual config is used #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AutoTune config to prefix scorer to make it explicit when auto vs. manual config is used #1888
Conversation
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
68f5cf0 to
7144e95
Compare
|
/hold Running some test |
…. manual config is used
7144e95 to
23d4d96
Compare
|
/lgtm |
|
/hold cancel |
Previously the prefix cache scorer implicitly overrides the BlockSize and LRUCapacityPerServer via model server metrics. This is the default behavior we want. However it can be confusing if users manually configure these parameters.
This PR adds an
autoTuneflag to the prefix cache scorer config to allow the user to explicitly set whether they want autoTune or not, and is defaulted totrue.This also allows use to manually set the CPU cache capacity because the corresponding metric isn't ready in vllm yet.
Test
Tried the following config:
And got the following log: