Switch goreleaser pull request to snapshot #182
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| name: goreleaser | ||
|
|
||
| on: | ||
| pull_request: |
Member
There was a problem hiding this comment.
Do we want to build --snapshot for PRs to verify that it works after merge?
Contributor
Author
There was a problem hiding this comment.
Yeah I'm just exploring this, I'll hold and have a go at that instead
Contributor
Author
|
/hold Going to try and get a snapshot build on PRs |
k8s-ci-robot
added
the
do-not-merge/hold
JoelSpeed
force-pushed
the
drop-pr-goreleaser
branch
from
9b31d94 to
99ae7fe
Compare
k8s-ci-robot
added
size/S
JoelSpeed
changed the title
Contributor
Author
|
/hold cancel This appears to be working as intended, will snapshot release on PRs now |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will now run a release snapshot on each PR to check that the project still builds correctly