Skip to content

Add support for dashboard v2.0.0 on dashboard-operator #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2020
Merged

Add support for dashboard v2.0.0 on dashboard-operator #74

merged 2 commits into from
Feb 26, 2020

Conversation

@atoato88
Copy link
Contributor

@atoato88 atoato88 commented Feb 5, 2020 •
edited
Loading

This PR adds support for dashboard v2.0.0 on dashboard-operator.

As of now, latest version is v2.0.0-rc3, so I add dashboard v2.0.0-rc3 as develop channel.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2020
@shu-mutou
Copy link

shu-mutou commented Feb 8, 2020

FYI: rc5 was released last night.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2020
@atoato88 atoato88 force-pushed the add-dashboard-v2.0.0-manifests branch 3 times, most recently from c632988 to 06386f5 Compare February 12, 2020 08:25
@johnsonj
Copy link
Contributor

johnsonj commented Feb 20, 2020

Thanks @atoato88 - Is this still WIP? Overall it looks good to me. Adding this as a develop channel is great to see!

also sorry for the delay! i've been on vacation.

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, johnsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@shu-mutou
Copy link

shu-mutou commented Feb 21, 2020

Kubernetes Dashboard 2.0.0 will be officially released by the end of March, please be patient. Thanks!

@shu-mutou
Copy link

shu-mutou commented Feb 21, 2020

Also, you can use image that includes latest commit on master branch from following:
https://hub.docker.com/u/kubernetesdashboarddev

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2020
@atoato88 atoato88 force-pushed the add-dashboard-v2.0.0-manifests branch from 06386f5 to 938556f Compare February 24, 2020 22:54
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2020
@atoato88
Copy link
Contributor Author

atoato88 commented Feb 25, 2020

/retitle Add support for dashboard v2.0.0 on dashboard-operator

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Add support for dashboard v2.0.0 on dashboard-operator Add support for dashboard v2.0.0 on dashboard-operator Feb 25, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2020
@atoato88
Copy link
Contributor Author

atoato88 commented Feb 26, 2020

@johnsonj
I've rabsed the code and retitled this PR (remove [WIP] and change PR description).
Could you recheck?

@johnsonj
Copy link
Contributor

johnsonj commented Feb 26, 2020

Thanks @atoato88 !

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 748a648 into kubernetes-sigs:master Feb 26, 2020
@atoato88 atoato88 deleted the add-dashboard-v2.0.0-manifests branch December 12, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@johnsonj johnsonj Awaiting requested review from johnsonj

Assignees

@johnsonj johnsonj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atoato88 @shu-mutou @johnsonj @k8s-ci-robot