use zero alloc read function in jsoniter

[lavalamp]

benchmark                                 old ns/op     new ns/op     delta
BenchmarkFieldSet/serialize-20-12         15649         15722         +0.47%
BenchmarkFieldSet/deserialize-20-12       36035         26974         -25.14%
BenchmarkFieldSet/serialize-50-12         37865         38637         +2.04%
BenchmarkFieldSet/deserialize-50-12       81147         66082         -18.57%
BenchmarkFieldSet/serialize-100-12        114218        118479        +3.73%
BenchmarkFieldSet/deserialize-100-12      224422        192446        -14.25%
BenchmarkFieldSet/serialize-500-12        617479        611650        -0.94%
BenchmarkFieldSet/deserialize-500-12      1053144       842299        -20.02%
BenchmarkFieldSet/serialize-1000-12       1236755       1160060       -6.20%
BenchmarkFieldSet/deserialize-1000-12     2054208       1669777       -18.71%

benchmark                                 old allocs     new allocs     delta
BenchmarkFieldSet/serialize-20-12         23             23             +0.00%
BenchmarkFieldSet/deserialize-20-12       216            141            -34.72%
BenchmarkFieldSet/serialize-50-12         48             48             +0.00%
BenchmarkFieldSet/deserialize-50-12       614            405            -34.04%
BenchmarkFieldSet/serialize-100-12        93             94             +1.08%
BenchmarkFieldSet/deserialize-100-12      2166           1441           -33.47%
BenchmarkFieldSet/serialize-500-12        470            470            +0.00%
BenchmarkFieldSet/deserialize-500-12      10779          7137           -33.79%
BenchmarkFieldSet/serialize-1000-12       999            998            -0.10%
BenchmarkFieldSet/deserialize-1000-12     23523          15604          -33.66%

This depends on json-iterator/go#394. It doesn't really move the needle on the main repo benchmarks, sadly. But I already did the work, so I'm just publishing it.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lavalamp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@lavalamp: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-structured-merge-diff-test	30d93ca	link	/test pull-structured-merge-diff-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lavalamp]

Actually let me retract that, it does do some good in the main repo, I had screwed up my go.mod rewrite rule:

benchmark                       old ns/op     new ns/op     delta
BenchmarkApplyNewObject-12      1953454       1928973       -1.25%
BenchmarkUpdateNewObject-12     2242290       2161230       -3.62%
BenchmarkRepeatedUpdate-12      781621        747257        -4.40%
BenchmarkSetToFields-12         5136          5359          +4.34%
BenchmarkFieldsToSet-12         10061         6531          -35.09%
BenchmarkYAMLToTyped-12         61988         63139         +1.86%

benchmark                       old allocs     new allocs     delta
BenchmarkApplyNewObject-12      6827           6827           +0.00%
BenchmarkUpdateNewObject-12     7913           7892           -0.27%
BenchmarkRepeatedUpdate-12      2288           2257           -1.35%
BenchmarkSetToFields-12         14             14             +0.00%
BenchmarkFieldsToSet-12         82             59             -28.05%
BenchmarkYAMLToTyped-12         152            152            +0.00%

[lavalamp]

The aggregate, overall improvement is:

benchmark                       old ns/op     new ns/op     delta
BenchmarkApplyNewObject-12      2230683       1928973       -13.53%
BenchmarkUpdateNewObject-12     2624417       2161230       -17.65%
BenchmarkRepeatedUpdate-12      1031653       747257        -27.57%
BenchmarkSetToFields-12         24778         5359          -78.37%
BenchmarkFieldsToSet-12         33876         6531          -80.72%
BenchmarkYAMLToTyped-12         68377         63139         -7.66%

benchmark                       old allocs     new allocs     delta
BenchmarkApplyNewObject-12      8632           6827           -20.91%
BenchmarkUpdateNewObject-12     11210          7892           -29.60%
BenchmarkRepeatedUpdate-12      3057           2257           -26.17%
BenchmarkSetToFields-12         124            14             -88.71%
BenchmarkFieldsToSet-12         147            59             -59.86%
BenchmarkYAMLToTyped-12         150            152            +1.33%

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@lavalamp: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.