Skip to content

Conversation

@jwforres
Copy link
Contributor

…to handle the exists operator for now

@jwforres
Copy link
Contributor Author

@spadgett this is to let us create a label selector from the UI code so that clicking on the key part of a label will add the key exists filter

@spadgett
Copy link
Contributor

So you pass JSON like this as the selector?

{
  "mykey": ""
}

Might be good to update the comment above the function that describes the param.

Just the one nit, code LGTM.

@jwforres
Copy link
Contributor Author

Actually I'm passing

{
  "mykey": null
}

Empty string actually seems to be a valid label value, so i need to update to check explicitly for null/undefined.

jwforres added a commit that referenced this pull request Oct 14, 2015
Allow creating a label selector object with a key mapped to no value …
@jwforres jwforres merged commit febf172 into kubernetes-ui:master Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants