Skip to content

Fix bug from 1.0.0 release where clear filter button wasn't re-rendered once filter had been cleared once #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2016
Merged

Fix bug from 1.0.0 release where clear filter button wasn't re-rendered once filter had been cleared once #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "kubernetes-label-selector",
"version": "1.0.0",
"version": "1.0.1",
"description": "Provides a LabelSelector object that understand kubernetes labels and label selector syntax, and works directly with JSON API objects from kubernetes. Also provides a label filtering widget.",
"moduleType": [
"globals"
Expand Down
4 changes: 3 additions & 1 deletion labelFilter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ angular.module('kubernetesUI')
)
).click(function() {
$(this).hide();
Copy link

@benjaminapetersen benjaminapetersen May 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 😄

self._labelFilterActiveFiltersElement.empty();
self._labelFilterActiveFiltersElement
.find('.label-filter-active-filter')
.remove();
self._clearActiveFilters();
});

Expand Down