Upgrade version of Patternfly and Bump Version to 2.1.0 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Sep 15, 2017
Contributor
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
LGTM, but I think we should either commit package-lock.json or disable it with package-lock=false in .npmrc
.gitignore
Outdated
| bower_components/* | ||
| node_modules/* | ||
| node_modules/* | ||
| package-lock.json |
Contributor
There was a problem hiding this comment.
This file should actually be committed to my understanding
Contributor
|
I'm OK committing package-lock.json unless you have a strong opinion @jeff-phillips-18 |
jeff-phillips-18
force-pushed
the
update
branch
from
eeed2a4 to
7a4d50b
Compare
Contributor
Author
|
@spadgett Yeah, I wasn't sure. I've added it. |
spadgett
approved these changes
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spadgett