Skip to content
This repository was archived by the owner on Apr 17, 2019. It is now read-only.

Conversation

@mwielgus
Copy link
Contributor

@mwielgus mwielgus commented May 2, 2016

kubernetes/kubernetes#24404

Requires that #866 is merged before.

cc: @piosz @fgrzadkowski

@mwielgus mwielgus force-pushed the check-nodes branch 4 times, most recently from eae66b7 to db37644 Compare May 4, 2016 12:58
@piosz piosz assigned piosz and unassigned fgrzadkowski May 4, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@piosz
Copy link
Contributor

piosz commented May 4, 2016

LGTM, please squash commits to have 2: one with godeps, second one with the real changes.

@piosz piosz added the lgtm Indicates that a PR is ready to be merged. label May 4, 2016
@mwielgus mwielgus merged commit 216a5ee into kubernetes-retired:master May 4, 2016
mwielgus added a commit to kubernetes/autoscaler that referenced this pull request Apr 18, 2017
…-nodes

Cluster-autoscaler - check generic predicates
mwielgus added a commit to kubernetes/autoscaler that referenced this pull request Apr 18, 2017
…-nodes

Cluster-autoscaler - check generic predicates
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants