-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Update Kubernetes deps to v1.16 #4346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4346 +/- ##
==========================================
- Coverage 46.62% 46.58% -0.05%
==========================================
Files 200 200
Lines 9374 9374
Branches 105 105
==========================================
- Hits 4371 4367 -4
- Misses 4734 4739 +5
+ Partials 269 268 -1
Continue to review full report at Codecov.
|
shu-mutou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find any trouble in all of npm commands, but few problems in UI.
When I logged in with token for kubernetes-dashboard namespace made by aio/deploy/recommended.yaml and selected namespace as kubernetes-dashboard:
- Replicaset made by
recommended.yamlcould not get its YAML inEditview. Browser console shows error 404. - In secret list view,
Opaquetype secrets made byrecommended.yamlcould not get its YAML inEditview. Browser console shows error 404. - In secret list view,
kubernetes-dashboard-certsandkubernetes-dashboard-key-holdermade byrecommended.yamlhasEditmenu, but it could not get its YAML and got 401 error. If user does not have permission, it's better to hideEditmenu, I think.
However, we could describe these problems as known issues and merge this PR, I think.
|
Edit for resources that the user has access to has to work, as it works with v1.15 now. Last issue exists on the current master I think, so we can create an issue for that and fix later. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The last one is described in Issue #4370. |
Closes #4327.
Using https://github.com/kubernetes/client-go/releases/tag/kubernetes-1.16.0.
Changes impacting our code: