Skip to content

Conversation

@maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Sep 26, 2019

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@maciaszczykm maciaszczykm changed the title [WIP] Update Kubernetes deps to v1.16 Update Kubernetes deps to v1.16 Sep 26, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2019
@maciaszczykm maciaszczykm requested review from shu-mutou and removed request for konryd September 26, 2019 13:59
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #4346 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4346      +/-   ##
==========================================
- Coverage   46.62%   46.58%   -0.05%     
==========================================
  Files         200      200              
  Lines        9374     9374              
  Branches      105      105              
==========================================
- Hits         4371     4367       -4     
- Misses       4734     4739       +5     
+ Partials      269      268       -1
Impacted Files Coverage Δ
...ackend/resource/customresourcedefinition/client.go 0% <0%> (ø) ⬆️
src/app/backend/resource/node/detail.go 51.33% <0%> (ø) ⬆️
src/app/backend/sync/secret.go 70.29% <0%> (-2.98%) ⬇️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0628fd...0cc808a. Read the comment docs.

Copy link
Contributor

@shu-mutou shu-mutou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any trouble in all of npm commands, but few problems in UI.

When I logged in with token for kubernetes-dashboard namespace made by aio/deploy/recommended.yaml and selected namespace as kubernetes-dashboard:

  • Replicaset made by recommended.yaml could not get its YAML in Edit view. Browser console shows error 404.
  • In secret list view, Opaque type secrets made by recommended.yaml could not get its YAML in Edit view. Browser console shows error 404.
  • In secret list view, kubernetes-dashboard-certs and kubernetes-dashboard-key-holder made by recommended.yaml has Edit menu, but it could not get its YAML and got 401 error. If user does not have permission, it's better to hide Edit menu, I think.

However, we could describe these problems as known issues and merge this PR, I think.

@floreks
Copy link
Member

floreks commented Sep 30, 2019

Edit for resources that the user has access to has to work, as it works with v1.15 now. Last issue exists on the current master I think, so we can create an issue for that and fix later.

@shu-mutou
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8f50246 into kubernetes:master Oct 2, 2019
@shu-mutou
Copy link
Contributor

Edit for resources that the user has access to has to work, as it works with v1.15 now. Last issue exists on the current master I think, so we can create an issue for that and fix later.

The last one is described in Issue #4370.

@maciaszczykm maciaszczykm deleted the feature/k8s-1.16 branch October 2, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Kubernetes v1.16

4 participants