Cinder in-tree to CSI driver migration

[davidz627]

Enhancement Description

• One-line enhancement description (can be used as a release note): Migrate the internals of in-tree Cinder Plugin to call out to the Cinder Driver while maintaining the original API
• Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md
• Primary contact (assignee): @adisky @dims
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release: 1.14
  • Beta release target: 1.18
  • Stable release target (x.y): 1.24

Parent enhancement: #625
Public Migration testing CI: LINK

TODO

• Replace design/KEP with specific one if needed
• Link public migration testing CI

[davidz627]

/sig storage

[jeremyrickard]

@davidz627 @dims @adisky I assume this is also being targeted for 1.18? The KEP currently doesn't have a Test Plan defined, it only references what is in the original design proposal. The release team would like to see the KEP updated to actually contain the test plan before enhancement freeze. We'll conditionally track this for 1.18 with that in mind if you're planning on going to beta in 1.18.

Thanks!

[jeremyrickard]

/milestone v1.19

[dims]

This is already done, please see kubernetes/kubernetes#85637 (comment)

[msau42]

/reopen
We should keep this issue open to track to GA

[k8s-ci-robot]

@msau42: Reopened this issue.

In response to this:

/reopen
We should keep this issue open to track to GA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

Hi @msau42 @davidz627 -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

As Jeremy mentioned above, it would be great if a test plan can be added before moving it to GA.

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[palnabarun]

Hi @msau42 @davidz627, pinging back as a reminder for the above. 🙂

[msau42]

I think we should remain in beta for 1.19 and work towards stabilizing the feature as well as getting it bundled with the openstack cloud controller. @adisky do you plan to continue working on this?

[palnabarun]

Thank you @msau42 for the update. I will update the tracking sheet accordingly. 👍

[palnabarun]

/milestone clear

[adisky]

I think we should remain in beta for 1.19 and work towards stabilizing the feature as well as getting it bundled with the openstack cloud controller. @adisky do you plan to continue working on this?

@msau42 I am no longer working on this, @chrigl @ramineni would be primary contacts.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @chrigl @ramineni @msau42

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[ramineni]

@kikisdeliveryservice Let me check on this on what needs to be done , will get back.

[msau42]

cc @jsafrane

[kikisdeliveryservice]

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20? To be included in the milestone:

The KEP must be merged in an implementable state
The KEP must have test plans (missing: need this for beta->GA)
The KEP must have graduation criteria

If you could please update to the new template and include the missing sections noted above that would be great. See for ref: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

I also note that the implementation history of the KEP also needs to be updated.

Thanks!
Kirsten

[ramineni]

@kikisdeliveryservice Sorry for the delay . Looks like it wont be possible for 1.20 , will target for next.
Thanks.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jsafrane]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jsafrane]

/remove-lifecycle stale

Update after 1.23 GA: it's still beta, to be GA in 1.24

[xing-yang]

/milestone v1.24

[Priyankasaggu11929]

Hello @msau42, @davidz627 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting stable for 1.24 and #3124 is the latest KEP PR, are these correct?

Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for this release
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review for stage stable that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

• update issue description with the latest Enhancements target and updated links (the KEP link is broken)
• update KEP-1489: add csi migration kep for openstack cinder #3124 PR to add test plan & graduation criteria and even it with the latest KEP template.

The status of this enhancement is track as at risk. Please update this issue description with appropriate stages as well. Thank you!

[Priyankasaggu11929]

All of the above criteria are satisfied now that the KEP PR #3124 has been merged. This enhancement is ready for the upcoming 1.24 enhancements freeze. 🚀

For note, the status of this enhancement is now tracked now. Thank you so much!

[PI-Victor]

Hi @msau42 @davidz627 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[Priyankasaggu11929]

Hello @msau42 @davidz627 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
• Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

• Next step in CSI migration for openstack kubernetes#107462

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

---

UPDATE (March 27, 2022)

From the PR updating KEP 1489 for milestone GA: #3124 (comment), I confirmed that kubernetes/kubernetes#107462 is the code implementation PR.

With that, the status of the enhancement is now tracked 🚀 . Thank you!

[PI-Victor]

Hi @msau42 @davidz627, please have a docs placeholder PR open by the 31st of March deadline. This PR can be empty for the time being. Thank you!

[xing-yang]

@PI-Victor Doc PR is already merged: kubernetes/website#32495
We are all set for this enhancement.

[Priyankasaggu11929]

Hello @msau42 @davidz627 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jsafrane]

Isn't it GA in 1.24? I filed #3462 to finish the KEP and close this issue