Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Cloud Provider Labels to GA #837

Open
andrewsykim opened this Issue Feb 15, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@andrewsykim
Copy link
Member

andrewsykim commented Feb 15, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Cloud provider labels we apply on nodes have been in "beta" for a very long time. Given their usage across the project we should GA them.

The 3 labels are:
beta.kubernetes.io/instance-type
failure-domain.beta.kubernetes.io/zone
failure-domain.beta.kubernetes.io/region

They should be renamed to:
topology.kubernetes.io/instance-type
topology.kubernetes.io/zone
topology.kubernetes.io/region

While keeping backwards compatibility in mind. Changing the label format may also be an option given we have to rename the label key anyways.

  • Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
    I'm working on the KEP right now, will update once the PR is open.

  • Primary contact (assignee):
    @andrewsykim

  • Responsible SIGs:
    SIG Cloud Provider, SIG Node

  • Enhancement target (which target equals to which milestone):

    • Stable release target (v1.15)
@andrewsykim

This comment has been minimized.

Copy link
Member Author

andrewsykim commented Feb 15, 2019

related #793

@andrewsykim

This comment has been minimized.

Copy link
Member Author

andrewsykim commented Feb 15, 2019

/sig cloud-provider

@andrewsykim

This comment has been minimized.

Copy link
Member Author

andrewsykim commented Feb 15, 2019

/kind api-change

related discussion in kubernetes/kubernetes#73616 (comment)

cc @liggitt @thockin @dims

@andrewsykim andrewsykim changed the title Promote Cloud Provider Node Labels to GA Promote Cloud Provider Labels to GA Feb 15, 2019

@andrewsykim

This comment has been minimized.

Copy link
Member Author

andrewsykim commented Feb 21, 2019

@MorrisLaw has volunteered to implement this once the KEP PR is merged, thank you!

@andrewsykim

This comment has been minimized.

Copy link
Member Author

andrewsykim commented Feb 28, 2019

Don't think this will make it to v1.14

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.