Skip to content

Add 1.9 release team #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2017
Merged

Add 1.9 release team #487

merged 1 commit into from
Oct 17, 2017

Conversation

@enisoc
Copy link
Contributor

@enisoc enisoc commented Oct 16, 2017 •
edited
Loading

Based on the nomination sheet as of Oct 16.

Please comment below to confirm acceptance of your role.

Role Name (GitHub/Slack ID) Shadow Name(s) (GitHub/Slack ID), ...
Lead Anthony Yeh (@enisoc)
Secondary Jaice Singer DuMars (@jdumars)
Features Ihor Dvoretskyi (@idvoretskyi)
Branch Manager David Ashpole (@dashpole)
Test Infra Benjamin Elder (@BenTheElder)
Docs Zach Corleissen (@zacharysarah)
Release Notes Jennifer Rondeau (@Bradamant3) Nick Chase (@nickchase), Peter Zhao (@xiangpengzhao)
Bugs Josh Berkus (@jberkus)
Upgrade Testing / CI Signal Aaron Crickenberger (@spiffxp) Jason DeTiberus (@detiber/@jdetiber)
Patch Release Manager Mehdy Bohlool (@mbohlool)
Marketing coordinator Natasha Woods (@nwoods3) Wendy Cartee (@wcartee), Paris Pittman (@parispittman)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2017
@dashpole
Copy link
Contributor

dashpole commented Oct 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2017
@BenTheElder
Copy link
Member

BenTheElder commented Oct 16, 2017

/lgtm 2

@idvoretskyi
Copy link
Member

idvoretskyi commented Oct 17, 2017

/lgtm

idvoretskyi
idvoretskyi approved these changes Oct 17, 2017
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangpengzhao
Copy link

xiangpengzhao commented Oct 17, 2017

+1 from me.
BTW, I find that Nick Chase didn't provide github handle or slack ID in the nomination sheet. There is a @nickchase on github. @nickchase is this you? :)

@zacharysarah
Copy link
Contributor

zacharysarah commented Oct 17, 2017

LGTM. I'll ask about a docs shadow in the SIG meeting tomorrow.

@jdumars
Copy link
Contributor

jdumars commented Oct 17, 2017

/lgtm

@mbohlool
Copy link
Contributor

mbohlool commented Oct 17, 2017

/lgtm

@detiber
Copy link
Contributor

detiber commented Oct 17, 2017

@enisoc one minor correction, my github and slack ids do not match. @detiber is correct for github, but I am @jdetiber on slack.

@enisoc
Copy link
Contributor Author

enisoc commented Oct 17, 2017

@detiber Thanks! Updated.

I've received explicit (here) or implicit (on other threads) acceptance from all the non-shadow roles except @spiffxp and @jberkus.

I'll go ahead and merge this and follow up with them individually.

@enisoc enisoc merged commit 985e5db into master Oct 17, 2017
@enisoc enisoc deleted the 1.9-release-team branch October 17, 2017 23:54
@spiffxp
Copy link
Contributor

spiffxp commented Oct 18, 2017

@enisoc whoops, missed this... yes, I'm good

@jberkus
Copy link
Contributor

jberkus commented Oct 20, 2017

lgtm

will ping you on Slack.

justaugustus pushed a commit to justaugustus/enhancements that referenced this pull request Sep 3, 2018
@childsb
Merge pull request kubernetes#487 from gnufied/fix-mount-options-proposa
fbd2e67 
Fix mount options proposal to be accurate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spiffxp spiffxp Awaiting requested review from spiffxp

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@jdumars jdumars Awaiting requested review from jdumars

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

@dashpole dashpole Awaiting requested review from dashpole

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

2 more reviewers

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@mbohlool mbohlool mbohlool approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@idvoretskyi idvoretskyi

@calebamiles calebamiles

@jdumars jdumars

@mbohlool mbohlool

@dashpole dashpole

@pwittrock pwittrock

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.