Skip to content

Fix typo #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2019
Merged

Fix typo #147

merged 1 commit into from
Mar 26, 2019

Conversation

@PhilippeDupont
Copy link
Contributor

@PhilippeDupont PhilippeDupont commented Feb 14, 2019

No description provided.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 14, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 14, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2019
@PhilippeDupont
Copy link
Contributor Author

PhilippeDupont commented Feb 14, 2019

CLA signed

@stp-ip
Copy link
Member

stp-ip commented Feb 14, 2019

/check-cla

@stp-ip
Copy link
Member

stp-ip commented Feb 14, 2019

Good catch. Thanks for pushing a fix.

thockin
thockin reviewed Feb 15, 2019
View reviewed changes
docs/ssh.md Outdated
git@github.com/foo/bar) , and set the `-ssh` flags (or set GIT_SYNC_SSH to
"true"). You will also need to set your container's `securityContext` to run
as user ID "65535" which is created for running git-syn as non-root.
as user ID "65533" which is created for running git-syn as non-root.
Copy link
Member

@thockin thockin Feb 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix "git-syn" at the same time? :)

@PhilippeDupont
Copy link
Contributor Author

PhilippeDupont commented Feb 21, 2019

Pushed with personal email

@PhilippeDupont
Copy link
Contributor Author

PhilippeDupont commented Feb 21, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 21, 2019
@stp-ip
Copy link
Member

stp-ip commented Mar 24, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2019
@cjwagner cjwagner mentioned this pull request Mar 25, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit aa241c2 into kubernetes:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin thockin left review comments

@stp-ip stp-ip Awaiting requested review from stp-ip

Assignees

@stp-ip stp-ip

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PhilippeDupont @k8s-ci-robot @stp-ip @thockin