Add GIT_SYNC_ROOT change for non-root user in docs/ssh #354

shubhamc183 · 2021-03-17T15:14:15Z

https://github.com/kubernetes/git-sync/pull/97\#issuecomment-800606819

shubhamc183 · 2021-03-17T15:15:00Z

k8s-ci-robot · 2021-03-17T15:16:50Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-03-17T15:16:54Z

Welcome @shubhamc183!

It looks like this is your first PR to kubernetes/git-sync 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/git-sync has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

thockin

Also needs you to sign CLA. Thanks!

thockin · 2021-03-17T17:11:32Z

docs/ssh.md

 change these last blocks to any UID/GID you like.  SSH demands that the current
 UID be present in /etc/passwd, so in this case you will need to add the
-`--add-user` flag to git-sync's args array.
+`--add-user` flag to git-sync's args array. Also, you need to change `GIT_SYNC_ROOT` to some other location, say `/workspace`, instead of `$HOME/git` as the `$HOME` will be `/` for the user and, `GIT_SYNC_ROOT` will end up in `//tmp` which do not exist.


Super nit-pick - can you please linewrap to match the rest? :)

Also "//tmp which do not exist" -> "//git which the non-root user can't create"

thockin · 2021-03-17T18:07:36Z

docs/ssh.md

+`--add-user` flag to git-sync's args array. Also, you need to change
+`GIT_SYNC_ROOT` to some other location, say `/workspace`, instead of
+`$HOME/git` as the `$HOME` will be `/` for the user and, `GIT_SYNC_ROOT` will
+end up in `//git` which do not exist.


last pick: s/do/does

Sorry, I did not understand this.

sorry, - please change "do" to "does" (blame English)

Actually, I changed it to "//git which the non-root user can't create" as suggested by you previously.

Also, I created an account in Linux Foundation ID Portal account with the correct same e-mail address but didn't get the email agreement to sign for CLA.

@caniszczyk - how can we poke the CLA machinery to check this?

Are you sure it was the same email you used for this commit (sh...183@gmail.com) ?

Check your spam and make sure? We're stuck until it is resolved. :(

https://github.com/kubernetes/git-sync/pull/97\#issuecomment-800606819

…lease-3.x

thockin · 2021-03-18T16:59:24Z

docs/ssh.md

-`--add-user` flag to git-sync's args array.
+`--add-user` flag to git-sync's args array. Also, you need to change
+`GIT_SYNC_ROOT` to some other location, say `/workspace`, instead of
+`$HOME/git` as the `$HOME` will be `/` for the user and, `GIT_SYNC_ROOT` will


While we wait for CLA - the , in this sentence is not needed :)

thockin · 2021-03-18T19:05:06Z

Thanks!

/lgtm
/approve

k8s-ci-robot · 2021-03-18T19:05:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shubhamc183, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shubhamc183 · 2021-03-19T17:16:51Z

I have used the same username and email.

I didn't get the email agreement to sign checked even in my Spam and other folders.

thockin · 2021-03-19T17:30:50Z

I'm told you can open a ticket at https://support.linuxfoundation.org/ for CLA issues.

shubhamc183 · 2021-03-25T04:54:26Z

/check-cla

Add GIT_SYNC_ROOT change for non-root user in docs/ssh

0e5426b

https://github.com/kubernetes/git-sync/pull/97\#issuecomment-800606819

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 17, 2021

k8s-ci-robot requested review from stp-ip and thockin March 17, 2021 15:16

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2021

thockin reviewed Mar 17, 2021

View reviewed changes

linewrap

c4a78d6

thockin reviewed Mar 17, 2021

View reviewed changes

shubhamc183 added 5 commits March 17, 2021 23:40

minor

35f1f18

Add GIT_SYNC_ROOT change for non-root user in docs/ssh

b6bed08

https://github.com/kubernetes/git-sync/pull/97\#issuecomment-800606819

linewrap

24be40d

minor

5310a22

Merge branch 'release-3.x' of github.com:shubhamc183/git-sync into re…

848eb4e

…lease-3.x

thockin reviewed Mar 18, 2021

View reviewed changes

minor

25e76a0

thockin added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 18, 2021

k8s-ci-robot assigned thockin Mar 18, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 25, 2021

k8s-ci-robot merged commit 3282883 into kubernetes:release-3.x Mar 25, 2021

Add GIT_SYNC_ROOT change for non-root user in docs/ssh #354

Add GIT_SYNC_ROOT change for non-root user in docs/ssh #354

Conversation

shubhamc183 commented Mar 17, 2021

Uh oh!

shubhamc183 commented Mar 17, 2021

Uh oh!

k8s-ci-robot commented Mar 17, 2021

Uh oh!

k8s-ci-robot commented Mar 17, 2021

Uh oh!

thockin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thockin commented Mar 18, 2021

Uh oh!

k8s-ci-robot commented Mar 18, 2021

Uh oh!

shubhamc183 commented Mar 19, 2021

Uh oh!

thockin commented Mar 19, 2021

Uh oh!

shubhamc183 commented Mar 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants