Skip to content

Conversation

@sunya-ch
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The test for DRA Consumable Capacity failed when #133960 has been applied together with suggested change that ensures the pod will be created even the flag is set and duration is zero.

The failure might relate to the bug report in #133705. To reduce complexity of the current test case, I simplify the test case by limit to single device and remove the counter reference from Partitionable Device feature.

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#5075
Related to: #133960

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

@sunya-ch: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd-2-0-dra-alpha-beta-features 5483c52 link false /test pull-kubernetes-node-e2e-containerd-2-0-dra-alpha-beta-features

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 10, 2025
@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Sep 10, 2025
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I verified in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/133960/pull-kubernetes-integration/1965667620468297728 that the test passes when pod scheduling is enforced.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 98343cb60f79ba88ff8f41035e49864ce54c834a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, sunya-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@pohly
Copy link
Contributor

pohly commented Sep 10, 2025

/skip

@k8s-ci-robot k8s-ci-robot merged commit 2e13e70 into kubernetes:master Sep 10, 2025
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 10, 2025
@sunya-ch sunya-ch deleted the simplified-consumable-capacity-integration-test branch September 10, 2025 12:01
@pohly pohly moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Sep 10, 2025
@sunya-ch sunya-ch changed the title DRA: Fix ConsumableCapacity shceduler perf test (simplified) DRA: Fix ConsumableCapacity scheduler perf test (simplified) Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants