-
Couldn't load subscription status.
- Fork 41.6k
DRA: Fix ConsumableCapacity scheduler perf test (simplified) #133983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRA: Fix ConsumableCapacity scheduler perf test (simplified) #133983
Conversation
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sunya-ch: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
I verified in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/133960/pull-kubernetes-integration/1965667620468297728 that the test passes when pod scheduling is enforced.
|
LGTM label has been added. Git tree hash: 98343cb60f79ba88ff8f41035e49864ce54c834a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, sunya-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/skip |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The test for DRA Consumable Capacity failed when #133960 has been applied together with suggested change that ensures the pod will be created even the flag is set and duration is zero.
The failure might relate to the bug report in #133705. To reduce complexity of the current test case, I simplify the test case by limit to single device and remove the counter reference from Partitionable Device feature.
Which issue(s) this PR is related to:
KEP: kubernetes/enhancements#5075
Related to: #133960
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: