Skip to content

Conversation

@ttsuuubasa
Copy link

@ttsuuubasa ttsuuubasa commented Oct 30, 2025

What type of PR is this?

/kind feature
/sig scheduling

What this PR does / why we need it:

This PR adds a test case to verify allocation behavior when a single ResourceSlice contains both devices with and without BindingConditions.
It ensures that two requests within a single ResourceClaim can successfully allocate both types of devices.
This scenario reflects realistic usage patterns and helps validate that the scheduler correctly handles mixed device conditions, improving test coverage and robustness.

Which issue(s) this PR is related to:

Part of KEP-5007: DRA Device Binding Conditions

Special notes for your reviewer:

@johnbelamaric @dom4ha

This PR is one of the enhancements of test for Device Binding Conditions (KEP-5007) targeting v1.35, and it fulfills one of the graduation criteria described in the KEP (originally listed as a beta graduation criterion).

  • Additional tests are in Testgrid and linked in KEP

To proactively meet the criteria for beta, we are considering merging this in the v1.35 alpha release.

@pohly

I’ve created one of the test cases you previously suggested in the comment.
Could you please take a look when you have a moment?

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/5007

Verify allocation behavior when a ResourceSlice contains both devices
with and without BindingConditions: ensure the both devices are successfully
allocated via two requests in a single ResourceClaim.

Signed-off-by: Tsubasa Watanabe <w.tsubasa@fujitsu.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

@ttsuuubasa: The label(s) kind/scheduler cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/kind scheduler

What this PR does / why we need it:

This PR adds a test case to verify allocation behavior when a single ResourceSlice contains both devices with and without BindingConditions.
It ensures that two requests within a single ResourceClaim can successfully allocate both types of devices.
This scenario reflects realistic usage patterns and helps validate that the scheduler correctly handles mixed device conditions, improving test coverage and robustness.

Which issue(s) this PR is related to:

Part of KEP-5007: DRA Device Binding Conditions

Special notes for your reviewer:

@johnbelamaric @dom4ha

This PR is one of the enhancements of test for Device Binding Conditions (KEP-5007) targeting v1.35, and it fulfills one of the graduation criteria described in the KEP (originally listed as a beta graduation criterion).

  • Additional tests are in Testgrid and linked in KEP

To proactively meet the criteria for beta, we are considering merging this in the v1.35 alpha release.

@pohly

I’ve created one of the test cases you previously suggested in the comment.
Could you please take a look when you have a moment?

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/5007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ttsuuubasa. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 30, 2025
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ttsuuubasa
Once this PR has been reviewed and has the lgtm label, please assign pohly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ttsuuubasa
Copy link
Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Oct 30, 2025
@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Status: 👀 In review
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants