Skip to content

test: refine vgs resources clean up #135250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test: refine vgs resources clean up #135250

wants to merge 3 commits into from
+233 −15

Conversation

@Phaow
Copy link
Contributor

@Phaow Phaow commented Nov 11, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Refine vgs resources clean up make sure all created resources cleaned up gracefully and fix previously test namespace stuck at Terminating status issue caused by the statefulset pvc does not delete in order.

Special notes for your reviewer:

  • I tested on my local verified that all created resources cleaned up gracefully:
    Click to Expand/Collapse Test Logs 
$ ./_output/bin/e2e.test \
  --provider=skeleton \
  --ginkgo.focus="\[Feature:volumegroupsnapshot\]" \
  --ginkgo.skip="\[Serial\]" \
  --num-nodes=2 \
  --kubeconfig=$HOME/.kube/config-kind \
  --ginkgo.v \
  --ginkgo.timeout=30m
...
  I1111 18:14:07.286295 82232 delete.go:86] Wait up to 5m0s for pod "pod-8190ec37-652a-47b8-ba63-e0b71f0e63a6" to be fully deleted
  I1111 18:14:09.294797 82232 volume_group_snapshottable.go:332] Deleting restored PVC restored-data-statefulset-vgs-volumegroupsnapshottable-1544-0
  I1111 18:14:09.305479 82232 volume_group_snapshottable.go:332] Deleting restored PVC restored-data-statefulset-vgs-volumegroupsnapshottable-1544-1
  I1111 18:14:09.314590 82232 volume_group_snapshottable.go:332] Deleting restored PVC restored-data-statefulset-vgs-volumegroupsnapshottable-1544-2
  I1111 18:14:09.330095 82232 volume_group_snapshottable.go:259] Deleting volumeGroupSnapshotResource group-snapshot-7t5z7
  I1111 18:14:09.330214 82232 volume_group_snapshot_resource.go:123] deleting groupSnapshot "volumegroupsnapshottable-1544"/"group-snapshot-7t5z7"
  I1111 18:14:09.335014 82232 volume_group_snapshot_resource.go:130] received snapshotStatus map[boundVolumeGroupSnapshotContentName:groupsnapcontent-986411eb-0fcc-452d-9f85-0567539f8906 creationTime:2025-11-11T10:13:54Z readyToUse:true]
  I1111 18:14:09.335083 82232 volume_group_snapshot_resource.go:131] groupSnapshotContentName groupsnapcontent-986411eb-0fcc-452d-9f85-0567539f8906
  I1111 18:14:09.348241 82232 utils.go:612] Waiting up to 5m0s for volumegroupsnapshots groupsnapcontent-986411eb-0fcc-452d-9f85-0567539f8906 to be deleted
  I1111 18:14:09.350067 82232 utils.go:617] volumegroupsnapshots groupsnapcontent-986411eb-0fcc-452d-9f85-0567539f8906 is not found and has been deleted
  I1111 18:14:09.350127 82232 utils.go:695] WaitUntil finished successfully after 1.688792ms
  I1111 18:14:09.350163 82232 volume_group_snapshot_resource.go:174] deleting group snapshot content "groupsnapcontent-986411eb-0fcc-452d-9f85-0567539f8906"
  I1111 18:14:09.366711 82232 utils.go:612] Waiting up to 5m0s for volumegroupsnapshotcontents groupsnapcontent-986411eb-0fcc-452d-9f85-0567539f8906 to be deleted
  I1111 18:14:09.371160 82232 utils.go:622] volumegroupsnapshotcontents groupsnapcontent-986411eb-0fcc-452d-9f85-0567539f8906 has been found and is not deleted
  I1111 18:14:11.376514 82232 utils.go:617] volumegroupsnapshotcontents groupsnapcontent-986411eb-0fcc-452d-9f85-0567539f8906 is not found and has been deleted
  I1111 18:14:11.376653 82232 utils.go:695] WaitUntil finished successfully after 2.009840542s
  I1111 18:14:11.376700 82232 volume_group_snapshot_resource.go:203] deleting group snapshot class "volumegroupsnapshottable-1544l6pz6"
  I1111 18:14:11.381537 82232 utils.go:612] Waiting up to 5m0s for volumegroupsnapshotclasses volumegroupsnapshottable-1544l6pz6 to be deleted
  I1111 18:14:11.384144 82232 utils.go:617] volumegroupsnapshotclasses volumegroupsnapshottable-1544l6pz6 is not found and has been deleted
  I1111 18:14:11.384250 82232 utils.go:695] WaitUntil finished successfully after 2.606417ms
  I1111 18:14:11.384295 82232 volume_group_snapshottable.go:264] Deleted volumeGroupSnapshotResource group-snapshot-7t5z7
  I1111 18:14:11.384442 82232 volume_group_snapshottable.go:235] Deleting StatefulSet statefulset-vgs-volumegroupsnapshottable-1544
  I1111 18:14:11.387719 82232 rest.go:153] Scaling statefulset statefulset-vgs-volumegroupsnapshottable-1544 to 0
  I1111 18:15:51.400341 82232 wait.go:160] Waiting for statefulset status.replicas updated to 0
  I1111 18:15:51.403740 82232 rest.go:91] Deleting statefulset statefulset-vgs-volumegroupsnapshottable-1544
  I1111 18:15:51.412575 82232 rest.go:111] Deleting pvc: csi-hostpathwzhn7 with volume pvc-8bc26d2f-2f07-4770-9934-b2d4bacbd372
  I1111 18:15:51.419405 82232 rest.go:137] Still waiting for pvs of statefulset to disappear:
  pvc-8bc26d2f-2f07-4770-9934-b2d4bacbd372: {Phase:Bound Message: Reason: LastPhaseTransitionTime:2025-11-11 18:13:12 +0800 CST}
  I1111 18:16:01.426062 82232 volume_group_snapshottable.go:240] Deleting volume resource
  STEP: Deleting pvc @ 11/11/25 18:16:01.426
  I1111 18:16:01.426266 82232 pv.go:205] Deleting PersistentVolumeClaim "csi-hostpathwzhn7"
  I1111 18:16:01.429945 82232 pv.go:863] Waiting up to 20m0s for PersistentVolume pvc-8bc26d2f-2f07-4770-9934-b2d4bacbd372 to get deleted
  I1111 18:16:01.432787 82232 pv.go:871] PersistentVolume pvc-8bc26d2f-2f07-4770-9934-b2d4bacbd372 was removed
  STEP: Deleting sc @ 11/11/25 18:16:01.432
  STEP: uninstalling csi csi-hostpath driver @ 11/11/25 18:16:01.438
  STEP: deleting the driver namespace: volumegroupsnapshottable-1544-9796 @ 11/11/25 18:16:01.438
  STEP: Waiting for namespaces [volumegroupsnapshottable-1544-9796] to vanish @ 11/11/25 18:16:01.444
  I1111 18:16:13.549708 82232 helper.go:125] Waiting up to 7m0s for all (but 0) nodes to be ready
  STEP: Destroying namespace "volumegroupsnapshottable-1544" for this suite. @ 11/11/25 18:16:13.552
• [183.765 seconds]
...
[SynchronizedAfterSuite] 
k8s.io/kubernetes/test/e2e/e2e.go:80
  I1111 18:16:13.567659 82232 suites.go:34] Running AfterSuite actions on node 1
[SynchronizedAfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Invariant Metrics
k8s.io/kubernetes/test/e2e/invariants/metrics.go:46
[ReportAfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Kubernetes e2e suite report
k8s.io/kubernetes/test/e2e/e2e_test.go:158
[ReportAfterSuite] PASSED [0.000 seconds]
------------------------------

Ran 1 of 7218 Specs in 183.927 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 7217 Skipped
PASS

# No Terminating test namespaces after test finished
$ oc get ns
NAME                 STATUS   AGE
default              Active   47d
kube-node-lease      Active   47d
kube-public          Active   47d
kube-system          Active   47d
local-path-storage   Active   47d

Which issue(s) this PR is related to:

N/A

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3476-volume-group-snapshot/

@Phaow
test: refine vgs resources clean up
ac25eb0 
Signed-off-by: Penghao <pewang@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 11, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 11, 2025
@Phaow
Copy link
Contributor Author

Phaow commented Nov 11, 2025

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 11, 2025
@Phaow
Copy link
Contributor Author

Phaow commented Nov 11, 2025

/test pull-kubernetes-e2e-storage-kind-volume-group-snapshots

@Phaow
Copy link
Contributor Author

Phaow commented Nov 11, 2025

Hi @jsafrane , could you help take a look when you get a chance? Thank you! ^^

@Phaow
Copy link
Contributor Author

Phaow commented Nov 11, 2025

/assign @jsafrane

jsafrane
jsafrane reviewed Nov 11, 2025
View reviewed changes
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Phaow
Once this PR has been reviewed and has the lgtm label, please ask for approval from jsafrane. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Phaow
Copy link
Contributor Author

Phaow commented Nov 13, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 13, 2025
@Phaow
Copy link
Contributor Author

Phaow commented Nov 13, 2025

/test pull-kubernetes-e2e-storage-kind-volume-group-snapshots

@Phaow Phaow requested a review from jsafrane November 13, 2025 07:19
@Phaow
fix: refine structure
8bd2272 
Signed-off-by: Penghao <pewang@redhat.com>
@Phaow
Copy link
Contributor Author

Phaow commented Nov 13, 2025

/test pull-kubernetes-e2e-storage-kind-volume-group-snapshots

@Phaow
Copy link
Contributor Author

Phaow commented Nov 14, 2025

/test pull-kubernetes-integration

@Phaow
Copy link
Contributor Author

Phaow commented Nov 14, 2025

Hi @jsafrane , could you help take a look again when you get a chance? Thank you! ^^

jsafrane
jsafrane reviewed Nov 14, 2025
View reviewed changes
@Phaow
fix: typo and proper data structure usage
b8f93b1 
Signed-off-by: Penghao <pewang@redhat.com>
@Phaow
Copy link
Contributor Author

Phaow commented Nov 14, 2025

/test pull-kubernetes-e2e-storage-kind-volume-group-snapshots

@Phaow Phaow requested a review from jsafrane November 14, 2025 14:51
@Phaow
Copy link
Contributor Author

Phaow commented Nov 15, 2025

/test pull-kubernetes-node-e2e-containerd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@xing-yang xing-yang Awaiting requested review from xing-yang

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

Labels

area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Phaow @k8s-ci-robot @jsafrane