Skip to content

add HOME env variable for kube-addons service #23975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2016
Merged

add HOME env variable for kube-addons service #23975

merged 1 commit into from
Apr 17, 2016

Conversation

@zhouhaibing089
Copy link
Contributor

Fix #23973.

Briefly, systemd service does not know the HOME environment variable which causes the kubectl write schema file into /.kube while it is expected to be /root/.kube.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 7, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 7, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Apr 7, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Apr 7, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 7, 2016
@zhouhaibing089
Copy link
Contributor Author

@mikedanese any comments about this, should this be a bug fix or maybe it is an intended behavior to write kubectl schema into root dir.

@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Apr 12, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 12, 2016

GCE e2e build/test passed for commit db347be.

@k8s-bot
Copy link

k8s-bot commented Apr 14, 2016

GCE e2e build/test failed for commit db347be.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@zhouhaibing089
Copy link
Contributor Author

@k8s-bot test this issue #24161

@zhouhaibing089
Copy link
Contributor Author

From the logs:

[k8s.io] Dynamic provisioning
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:424
  [k8s.io] DynamicProvisioner
  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:424
    should create and delete persistent volumes [It]
    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/volume_provisioning.go:123

    Expected error:
        <*errors.errorString | 0xc8203670b0>: {
            s: "PersistentVolume pv-gce-zoxk6 still exists within 10m0s",
        }
        PersistentVolume pv-gce-zoxk6 still exists within 10m0s
    not to have occurred

    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/volume_provisioning.go:122

@zhouhaibing089
Copy link
Contributor Author

@mikedanese please help to trigger a retest..

@mikedanese
Copy link
Member

@k8s-bot test this issue #24161

@k8s-bot
Copy link

k8s-bot commented Apr 15, 2016

GCE e2e build/test passed for commit db347be.

@k8s-bot
Copy link

k8s-bot commented Apr 17, 2016

GCE e2e build/test passed for commit db347be.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Apr 17, 2016

GCE e2e build/test passed for commit db347be.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 273b01d into kubernetes:master Apr 17, 2016
jasonbrooks added a commit to jasonbrooks/contrib that referenced this pull request Apr 18, 2016
@jasonbrooks
add HOME env variable for kube-addons service
a7d9dd5 
Implements upstream change kubernetes/kubernetes#23975, which fixes kubernetes/kubernetes#23973.
@jasonbrooks jasonbrooks mentioned this pull request Apr 18, 2016
Merged
@jasonbrooks jasonbrooks mentioned this pull request Apr 25, 2016
Merged
openstack-gerrit pushed a commit to openstack/magnum that referenced this pull request May 19, 2016
Fix two issues on k8s bay
2534a15 
After upgrade to Kubernetes v1.2, there are two issues:
* kubelet cannot find the IP address of nodes [1]
* the systemd service kube-system-namespace failed because it doesnot
  know the HOME environment variable. Similar issue from upstream
  is: kubernetes/kubernetes#23975

This patch fixed them. First, set the HOME environment variable.
Second, override hostname with IP address.

[1] kubernetes/kubernetes#23130

Change-Id: I55df72c8f36d81852bde36018c17670101860f79
Closes-Bug: #1582625
Closes-Bug: #1583415
@zhouhaibing089 zhouhaibing089 deleted the kubectl-fix branch June 8, 2016 05:18
openstack-gerrit pushed a commit to openstack/magnum that referenced this pull request Oct 18, 2016
@yatinkarel
Fix failure of systemd service kube-ui
865702f 
The systemd service kube-ui failed because it does not
know the HOME environment variable.
Also updated script to handle already existing namespace,
rc and service.

Similar issue from upstream is as follows:
kubernetes/kubernetes#23975

Change-Id: I71925a232b57f3c2cdfe82ae97b3fd7395e37343
Co-Authored-By: yatinkarel <yatin.karel@nectechnologies.in>
Closes-Bug: #1584931
openstack-gerrit pushed a commit to openstack/magnum that referenced this pull request Nov 21, 2016
@yatinkarel
Fix failure of systemd service kube-ui
3f86cc4 
The systemd service kube-ui failed because it does not
know the HOME environment variable.
Also updated script to handle already existing namespace,
rc and service.

Similar issue from upstream is as follows:
kubernetes/kubernetes#23975

Change-Id: I71925a232b57f3c2cdfe82ae97b3fd7395e37343
Co-Authored-By: yatinkarel <yatin.karel@nectechnologies.in>
Closes-Bug: #1584931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mikedanese mikedanese

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhouhaibing089 @googlebot @k8s-bot @mikedanese @k8s-github-robot @k8s-teamcity-mesosphere