Skip to content

Conversation

@k82cn
Copy link
Contributor

@k82cn k82cn commented Apr 24, 2017

What this PR does / why we need it:
Fixed the following flaky unit test:

--- FAIL: TestGetEnvAsIntOrFallback (0.00s)
   Error Trace:    env_test.go:58
	Error:		Not equal: "strconv.ParseInt: parsing \"not-an-int\": invalid syntax" (expected)
			        != "strconv.Atoi: parsing \"not-an-int\": invalid syntax" (actual)
	Messages:	An error with value "strconv.ParseInt: parsing "not-an-int": invalid syntax" is expected but got "strconv.Atoi: parsing "not-an-int": invalid syntax".

FAIL
FAIL	k8s.io/kubernetes/pkg/util/env	0.005s

Release Note

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k82cn
We suggest the following additional approver: @brendandburns

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 24, 2017
@k82cn
Copy link
Contributor Author

k82cn commented Apr 24, 2017

Seems go 1.8 report different error message.

[root@ib15b13 kubernetes]# go version
go version go1.8 linux/amd64

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 24, 2017

@k82cn: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins Bazel Build 401a06d link @k8s-bot bazel test this
Jenkins unit/integration 401a06d link @k8s-bot unit test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k82cn
Copy link
Contributor Author

k82cn commented Apr 24, 2017

go version issue, close it firstly.

@k82cn k82cn closed this Apr 24, 2017
@k82cn k82cn deleted the flaky_ut branch April 24, 2017 08:57
@ixdy
Copy link
Contributor

ixdy commented Apr 27, 2017

This was fixed in #44583.

@k82cn
Copy link
Contributor Author

k82cn commented Apr 28, 2017

@ixdy , got that; thanks :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants