- 
                Notifications
    
You must be signed in to change notification settings  - Fork 41.6k
 
Adding more kernel config paths #69614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks. 
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.  | 
    
| 
           /assign @timothysc  | 
    
| 
           I signed the CLA.  | 
    
| 
           this spawned from this thread in /kind: TLDR kind deploys kubeadm in a container that doesn't conform our kernel validator about location for the IKCONFIG and it throws preflight warnings. i'm OK with these two new lines, as long as we don't have a few dozens of paths to handle all possible paths that distros "invent". /cc @BenTheElder  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
| 
           [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mitar, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
      
 Approvers can indicate their approval by writing   | 
    
| 
           /retest  | 
    
What this PR does / why we need it:
This adds additional paths to find
.configfile which seems to work on the default Ubuntu 18.04 LTS installation."/boot/config-" + k.kernelRelease,from that list already finds one combination, but this is not always available. In the case I am interested in it is not available because I am running Kubernetes inside a Docker container, so it requires to volume mount/bootinto the container. This is one way to address this, but another is also to find in multiple other paths because they might be mounted in for other reasons. For example,/lib/modules/might be mounted in to give (a privileged) container access to additional kernel modules, and if Kubernetes also checks for.configfile there, this helps.Release note: