test/e2e/framework move func logClusterImageSources to test/e2e/e2e.go #89676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Contributor
Author
|
/priority backlog |
k8s-ci-robot
added
the
priority/backlog
Contributor
|
@tanjunchen: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
kind/cleanup
Contributor
Author
|
/cc @oomichi |
tanjunchen
commented
Mar 31, 2020
| "expect.go", | ||
| "flake_reporting_util.go", | ||
| "framework.go", | ||
| "google_compute.go", |
Contributor
Author
There was a problem hiding this comment.
attention:
This function is in test/e2e/framework/google_compute.go
k8s-ci-robot
added
the
lgtm
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi, tanjunchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
jbartosik
added a commit
to jbartosik/autoscaler
that referenced
this pull request
Sep 6, 2021
1. IsRetryableAPIError is no longer needed, stop using it kubernetes/kubernetes#95495 2. LogClusterImageSources is now private, stop using it kubernetes/kubernetes#89676 3. DeleteResourceAndWaitForGC was moved 4. k8s.io/kubernetes/test/e2e/manifest was moved
piotrnosek
pushed a commit
to piotrnosek/autoscaler
that referenced
this pull request
Nov 30, 2021
1. IsRetryableAPIError is no longer needed, stop using it kubernetes/kubernetes#95495 2. LogClusterImageSources is now private, stop using it kubernetes/kubernetes#89676 3. DeleteResourceAndWaitForGC was moved 4. k8s.io/kubernetes/test/e2e/manifest was moved
MaxRink
pushed a commit
to MaxRink/autoscaler
that referenced
this pull request
Feb 14, 2022
1. IsRetryableAPIError is no longer needed, stop using it kubernetes/kubernetes#95495 2. LogClusterImageSources is now private, stop using it kubernetes/kubernetes#89676 3. DeleteResourceAndWaitForGC was moved 4. k8s.io/kubernetes/test/e2e/manifest was moved
tim-smart
pushed a commit
to arisechurch/autoscaler
that referenced
this pull request
Nov 22, 2022
1. IsRetryableAPIError is no longer needed, stop using it kubernetes/kubernetes#95495 2. LogClusterImageSources is now private, stop using it kubernetes/kubernetes#89676 3. DeleteResourceAndWaitForGC was moved 4. k8s.io/kubernetes/test/e2e/manifest was moved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
LogClusterImageSources is only used in test/e2e/e2e.go , so move it to there.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: