Skip to content

Cleanup dependencies in changelog #98347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

Cleanup dependencies in changelog #98347

merged 1 commit into from
Mar 2, 2021

Conversation

@chymy
Copy link
Contributor

@chymy chymy commented Jan 25, 2021 •
edited
Loading

Signed-off-by: chymy chang.min1@zte.com.cn

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Contains duplicate Dependencies , words and parameters misspelling in changelog-1.20 and changelog-1.19.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 25, 2021

Hi @chymy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 25, 2021
@chymy
Copy link
Contributor Author

chymy commented Jan 26, 2021

Please take a look, Thanks.
/assign @hasheddan @feiskyer

hasheddan
hasheddan suggested changes Jan 26, 2021
View reviewed changes
@chymy chymy force-pushed the changelog20-2021125 branch from e6b7636 to c433189 Compare January 26, 2021 02:14
@chymy chymy requested a review from hasheddan January 27, 2021 08:25
@chymy
Copy link
Contributor Author

chymy commented Jan 27, 2021 •
edited
Loading

Could you take a look?
Thanks.
/assign @wilsonehusin @justaugustus

@wilsonehusin
Copy link
Contributor

wilsonehusin commented Feb 1, 2021

@chymy, please incorporate #98652 and #98654 in this PR together.

@chymy chymy force-pushed the changelog20-2021125 branch from 391892e to 6e498a2 Compare February 2, 2021 02:20
@chymy
Copy link
Contributor Author

chymy commented Feb 2, 2021

@chymy, please incorporate #98652 and #98654 in this PR together.

Thank you very much @wilsonehusin, fixed.

@wilsonehusin
Copy link
Contributor

wilsonehusin commented Feb 2, 2021

/triage accepted
/ok-to-test
/retitle Cleanup dependencies in 1.20 changelog

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 2, 2021
@k8s-ci-robot k8s-ci-robot changed the title Remove duplicate 'Dependencies' in changelog-1.20 Cleanup dependencies in 1.20 changelog Feb 2, 2021
@k8s-ci-robot k8s-ci-robot removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 2, 2021
@chymy chymy force-pushed the changelog20-2021125 branch 2 times, most recently from 4573dab to 064b19d Compare February 18, 2021 03:31
@chymy
Copy link
Contributor Author

chymy commented Feb 18, 2021

/test pull-kubernetes-bazel-build

@chymy
Copy link
Contributor Author

chymy commented Feb 18, 2021

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2021
@chymy
Remove redundant 'Dependencies' in changelog-1.20
fa34baa 
Signed-off-by: chymy <chang.min1@zte.com.cn>
@chymy chymy force-pushed the changelog20-2021125 branch from 064b19d to fa34baa Compare February 20, 2021 02:22
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2021
@chymy chymy changed the title Cleanup dependencies in 1.20 changelog Cleanup dependencies in changelog Feb 20, 2021
@chymy
Copy link
Contributor Author

chymy commented Feb 20, 2021

/test pull-kubernetes-e2e-kind

@chymy
Copy link
Contributor Author

chymy commented Feb 20, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@chymy
Copy link
Contributor Author

chymy commented Feb 23, 2021

/test pull-kubernetes-e2e-kind

@chymy
Copy link
Contributor Author

chymy commented Feb 23, 2021

/retest

@chymy
Copy link
Contributor Author

chymy commented Mar 1, 2021

/test pull-kubernetes-e2e-kind

@wilsonehusin
Copy link
Contributor

wilsonehusin commented Mar 1, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chymy, wilsonehusin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@chymy
Copy link
Contributor Author

chymy commented Mar 2, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6d64dfe into kubernetes:master Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 2, 2021
@wilsonehusin wilsonehusin mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees

@feiskyer feiskyer

@wilsonehusin wilsonehusin

@hasheddan hasheddan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

5 participants

@chymy @k8s-ci-robot @wilsonehusin @hasheddan @feiskyer