Skip to content

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Jan 9, 2025

Reverts #20183

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from spowelljr January 9, 2025 23:25
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2025
@ComradeProgrammer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 10, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20229) |
+----------------+----------+---------------------+
| minikube start | 53.4s    | 53.3s               |
| enable ingress | 17.6s    | 16.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 18.6s 19.0s 16.5s 18.6s 15.1s
Times for minikube (PR 20229) ingress: 15.1s 15.1s 18.6s 16.1s 16.6s

Times for minikube start: 54.7s 55.0s 52.7s 53.3s 51.5s
Times for minikube (PR 20229) start: 52.5s 53.0s 53.9s 53.4s 53.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20229) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 22.0s               |
| enable ingress | 12.4s    | 12.6s               |
+----------------+----------+---------------------+

Times for minikube start: 24.2s 23.7s 21.8s 24.8s 24.7s
Times for minikube (PR 20229) start: 21.4s 21.6s 23.8s 22.4s 21.1s

Times for minikube ingress: 12.3s 12.3s 12.3s 12.3s 12.8s
Times for minikube (PR 20229) ingress: 12.3s 12.8s 13.3s 12.3s 12.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20229) |
+----------------+----------+---------------------+
| minikube start | 20.4s    | 22.6s               |
| enable ingress | 29.2s    | 25.5s               |
+----------------+----------+---------------------+

Times for minikube start: 19.6s 20.7s 20.4s 20.8s 20.2s
Times for minikube (PR 20229) start: 22.3s 24.1s 23.0s 20.3s 23.3s

Times for minikube ingress: 38.8s 22.8s 22.8s 38.8s 22.8s
Times for minikube (PR 20229) ingress: 22.8s 29.8s 29.0s 22.9s 22.8s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 03d4a5a into master Jan 13, 2025
37 of 49 checks passed
@medyagh medyagh deleted the revert-20183-dependabot/go_modules/k8s.io/client-go-0.32.0 branch May 27, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants