Move hyperv and virtualbox drivers to minikube

[afbjorklund]

BEFORE

vendor/github.com/docker/machine/drivers/hyperv/
├── hyperv.go
└── powershell.go
vendor/github.com/docker/machine/drivers/virtualbox/
├── disk.go
├── ip.go
├── misc.go
├── network.go
├── vbm.go
├── virtualbox_darwin.go
├── virtualbox_freebsd.go
├── virtualbox.go
├── virtualbox_linux.go
├── virtualbox_openbsd.go
├── virtualbox_windows.go
├── vm.go
├── vtx.go
├── vtx_intel.go
└── vtx_other.go

AFTER

pkg/drivers/hyperv/
pkg/drivers/virtualbox/

--- a/pkg/minikube/registry/drvs/hyperv/hyperv.go
+++ b/pkg/minikube/registry/drvs/hyperv/hyperv.go
@@ -27,3 +27,2 @@ import (
 
-       "github.com/docker/machine/drivers/hyperv"
        "github.com/docker/machine/libmachine/drivers"
@@ -31,2 +30,3 @@ import (
 
+       "k8s.io/minikube/pkg/drivers/hyperv"
        "k8s.io/minikube/pkg/minikube/config"
--- a/pkg/minikube/registry/drvs/virtualbox/virtualbox.go
+++ b/pkg/minikube/registry/drvs/virtualbox/virtualbox.go
@@ -26,3 +26,2 @@ import (
 
-       "github.com/docker/machine/drivers/virtualbox"
        "github.com/docker/machine/libmachine/drivers"
@@ -30,2 +29,3 @@ import (
        "k8s.io/klog/v2"
+       "k8s.io/minikube/pkg/drivers/virtualbox"
        "k8s.io/minikube/pkg/minikube/config"

Preparing for making the libmachine API internal

Part of the issue to remove legacy docker machine:

• Remove old references to docker machine #21619

The other PR got too big to review, since it did both.

Both imported 4 drivers, and imported libmachine:

• Internalize github.com/docker/machine/libmachine #21647

---

We still need to import the other 2 (obsolete) drivers:

github.com/minikube-machine/machine-driver-parallels

• Copy the external parallels driver to internal #21968

github.com/minikube-machine/machine-driver-vmware

• Copy the external vmware driver to internal #21969

Before we can move the libmachine API over to internal.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afbjorklund]

Nice to get rid of the old Docker dependencies from the go.mod, when dropping the Docker Machine depends...

-github.com/docker/docker v0.0.0-20180621001606-093424bec097/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
-github.com/docker/docker v17.12.0-ce-rc1.0.20181225093023-5ddb1d410a8b+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
-github.com/docker/docker v17.12.0-ce-rc1.0.20190115220918-5ec31380a5d3+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
 github.com/docker/docker v28.3.3+incompatible h1:Dypm25kh4rmk49v1eiVbsAtpAsYURjYkaKubwuBdxEI=
 github.com/docker/docker v28.3.3+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
 ...
-github.com/moby/term v0.0.0-20200416134343-063f2cd0b49d/go.mod h1:DdlQx2hp0Ss5/fLikoLlEeIYiATotOjgB//nb973jeo=
 github.com/moby/term v0.5.0 h1:xt8Q1nalod/v7BqbG21f8mQPqH+xAaC9C3N3wfWbVP0=
 github.com/moby/term v0.5.0/go.mod h1:8FzsFHVUBGZdbDsJw/ot+X+d5HLUbvklYLJ9uGfcI3Y=

-github.com/minikube-machine/machine v0.0.0-20251109100456-3b479dcea7a3 h1:LO7khkb1P2LpqCL8GnqPBPn1lZeqA/bqRinjveU2EaQ=
-github.com/minikube-machine/machine v0.0.0-20251109100456-3b479dcea7a3/go.mod h1:wrzTHaSSmyll2TxLCq4mTFL5RJfeFr6qger+VcqNm9g=
-github.com/minikube-machine/machine-driver-parallels/v2 v2.0.2-0.20240730142131-ada9375ea417 h1:f+neTRGCtvmW3Tm1V72vWpoTPuNOnXSQsHZdYOryfGM=
-github.com/minikube-machine/machine-driver-parallels/v2 v2.0.2-0.20240730142131-ada9375ea417/go.mod h1:NKwI5KryEmEHMZVj80t9JQcfXWZp4/ZYNBuw4C5sQ9E=
-github.com/minikube-machine/machine-driver-vmware v0.1.6-0.20230701123042-a391c48b14d5 h1:1z7xOzfMO4aBR9+2nYjlhRXX1773fX60HTS0QGpGRPU=
-github.com/minikube-machine/machine-driver-vmware v0.1.6-0.20230701123042-a391c48b14d5/go.mod h1:HifYFOWR0bAMN4hWtaSADClogvtPy/jV0aRC5alhrKo=

[medyagh]

/ok-to-test

[k8s-ci-robot]

@afbjorklund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
integration-kvm-containerd-linux-x86-64	f7c9a93	link	true	/test integration-kvm-containerd-linux-x86-64
integration-kvm-crio-linux-x86-64	f7c9a93	link	true	/test integration-kvm-crio-linux-x86-64
integration-docker-crio-linux-x86-64	f7c9a93	link	true	/test integration-docker-crio-linux-x86-64
integration-docker-containerd-linux-x86-64	f7c9a93	link	true	/test integration-docker-containerd-linux-x86-64
integration-none-docker-linux-x86-64	f7c9a93	link	true	/test integration-none-docker-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[minikube-pr-bot]

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21966 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 39.7s    │ 40.5s                  │
│ enable ingress │ 15.6s    │ 15.4s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube (PR 21966) start: 41.3s 39.6s 40.4s 41.3s 39.7s
Times for minikube start: 39.5s 40.1s 38.1s 39.9s 40.8s

Times for minikube ingress: 15.7s 15.2s 15.8s 15.7s 15.7s
Times for minikube (PR 21966) ingress: 15.7s 14.8s 15.7s 15.2s 15.7s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21966 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.8s    │ 22.7s                  │
│ enable ingress │ 11.4s    │ 10.6s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 10.6s 10.6s 12.6s 10.6s 12.6s
Times for minikube (PR 21966) ingress: 10.6s 10.6s 10.6s 10.6s 10.6s

Times for minikube start: 24.8s 24.0s 21.0s 23.0s 21.1s
Times for minikube (PR 21966) start: 24.4s 23.9s 19.6s 24.6s 21.1s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21966 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.2s    │ 20.2s                  │
│ enable ingress │ 20.5s    │ 20.3s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 17.4s 20.9s 21.9s 19.3s 21.3s
Times for minikube (PR 21966) start: 18.8s 19.2s 22.6s 18.5s 21.8s

Times for minikube ingress: 20.1s 21.1s 20.1s 20.1s 21.1s
Times for minikube (PR 21966) ingress: 20.1s 21.1s 20.1s 20.1s 20.1s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
KVM_Linux_crio (1 failed)	TestAddons/parallel/CSI(gopogh)	14.00% (chart)
Docker_Linux_containerd (4 failed)	TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd (4 failed)	TestStartStop/group/embed-certs/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd (4 failed)	TestStartStop/group/no-preload/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd (4 failed)	TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh)	2.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestStartStop/group/no-preload/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestStartStop/group/embed-certs/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh)	0.00% (chart)
KVM_Linux (10 failed)	TestISOImage/PersistentMounts//data(gopogh)	Unknown
KVM_Linux (10 failed)	TestISOImage/PersistentMounts//var/lib/docker(gopogh)	Unknown
KVM_Linux (10 failed)	TestISOImage/PersistentMounts//var/lib/cni(gopogh)	Unknown
KVM_Linux (10 failed)	TestISOImage/PersistentMounts//var/lib/kubelet(gopogh)	Unknown
KVM_Linux (10 failed)	TestISOImage/PersistentMounts//var/lib/minikube(gopogh)	Unknown
KVM_Linux (10 failed)	TestISOImage/PersistentMounts//var/lib/toolbox(gopogh)	Unknown
KVM_Linux (10 failed)	TestISOImage/PersistentMounts//var/lib/boot2docker(gopogh)	Unknown
KVM_Linux (10 failed)	TestISOImage/VersionJSON(gopogh)	Unknown
KVM_Linux (10 failed)	TestISOImage/eBPFSupport(gopogh)	Unknown
KVM_Linux (10 failed)	TestStartStop/group/no-preload/serial/Pause(gopogh)	0.00% (chart)
Docker_Windows (1 failed)	TestErrorSpam/setup(gopogh)	Unknown

Besides the following environments also have failed tests:

• Docker_Linux_crio_arm64: 36 failed (gopogh)

• Docker_Linux_crio: 37 failed (gopogh)

To see the flake rates of all tests by environment, click here.