-
Notifications
You must be signed in to change notification settings - Fork 682
Adding helm chart info to readme and fixing some formatting #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding helm chart info to readme and fixing some formatting #217
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I signed it |
README.md
Outdated
| helm install stable/node-problem-detector | ||
| ``` | ||
|
|
||
| Alternatively you can edit [node-problem-detector.yaml](deployment/node-problem-detector.yaml) to fit your environment. Set `log` volume to your system log directory (used by SystemLogMonitor). For Kubernetes versions older than 1.9 use [node-problem-detector-old.yaml](deployment/node-problem-detector-old.yaml). Create the DaemonSet with `kubectl create -f deployment/node-problem-detector.yaml`. If needed, you can use a [ConfigMap](https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/) to overwrite the `config` directory inside the pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, you can edit node-problem-detector.yaml to fit your environment. Set log volume to your system log directory (used by SystemLogMonitor). For Kubernetes versions older than 1.9, use node-problem-detector-old.yaml.
- Create the DaemonSet with
kubectl create -f deployment/node-problem-detector.yaml. - If needed, you can use a ConfigMap to overwrite the
configdirectory inside the pod.
README.md
Outdated
| helm install stable/node-problem-detector | ||
| ``` | ||
|
|
||
| Alternatively you can edit [node-problem-detector.yaml](deployment/node-problem-detector.yaml) to fit your environment. Set `log` volume to your system log directory (used by SystemLogMonitor). For Kubernetes versions older than 1.9 use [node-problem-detector-old.yaml](deployment/node-problem-detector-old.yaml). Create the DaemonSet with `kubectl create -f deployment/node-problem-detector.yaml`. If needed, you can use a [ConfigMap](https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/) to overwrite the `config` directory inside the pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, you can edit node-problem-detector.yaml to fit your environment. Set log volume to your system log directory (used by SystemLogMonitor). For Kubernetes versions older than 1.9, use node-problem-detector-old.yaml.
- Create the DaemonSet with
kubectl create -f deployment/node-problem-detector.yaml. - If needed, you can use a ConfigMap to overwrite the
configdirectory inside the pod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@max-rocket-internet Thanks for updating this. I suggest adding some comma to make the sentences more readable. Please correct me if there are any un-comfortable changes for your. :) English is not my mother language.
I also suggest we keep the items format for create the daemonset and If needed to make the doc more readable. :)
|
@max-rocket-internet Just one nit. Others lgtm. |
Signed-off-by: Max Williams <max.williams@deliveryhero.com>
|
Hey @andyxning, I think I've implemented your suggestions, please check 🙂 |
|
@max-rocket-internet Could you please rebase from the master with the latest change for the |
|
@andyxning I don't really get what you mean. Can you be specific? |
Signed-off-by: Max Williams <max.williams@deliveryhero.com>
|
I think I understand now. Please re-review @andyxning 🙂 |
|
/lgtm Thanks @max-rocket-internet |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, max-rocket-internet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Now the a helm chart is available in the stable repo, I think we should include it here in the installation instructions. Especially since the YAML files in here are quite out of date.
https://github.com/helm/charts/tree/master/stable/node-problem-detector