Skip to content

Conversation

@max-rocket-internet
Copy link
Contributor

Now the a helm chart is available in the stable repo, I think we should include it here in the installation instructions. Especially since the YAML files in here are quite out of date.

https://github.com/helm/charts/tree/master/stable/node-problem-detector

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 2, 2018
@max-rocket-internet
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 2, 2018
README.md Outdated
helm install stable/node-problem-detector
```

Alternatively you can edit [node-problem-detector.yaml](deployment/node-problem-detector.yaml) to fit your environment. Set `log` volume to your system log directory (used by SystemLogMonitor). For Kubernetes versions older than 1.9 use [node-problem-detector-old.yaml](deployment/node-problem-detector-old.yaml). Create the DaemonSet with `kubectl create -f deployment/node-problem-detector.yaml`. If needed, you can use a [ConfigMap](https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/) to overwrite the `config` directory inside the pod.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, you can edit node-problem-detector.yaml to fit your environment. Set log volume to your system log directory (used by SystemLogMonitor). For Kubernetes versions older than 1.9, use node-problem-detector-old.yaml.

  • Create the DaemonSet with kubectl create -f deployment/node-problem-detector.yaml.
  • If needed, you can use a ConfigMap to overwrite the config directory inside the pod.

README.md Outdated
helm install stable/node-problem-detector
```

Alternatively you can edit [node-problem-detector.yaml](deployment/node-problem-detector.yaml) to fit your environment. Set `log` volume to your system log directory (used by SystemLogMonitor). For Kubernetes versions older than 1.9 use [node-problem-detector-old.yaml](deployment/node-problem-detector-old.yaml). Create the DaemonSet with `kubectl create -f deployment/node-problem-detector.yaml`. If needed, you can use a [ConfigMap](https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/) to overwrite the `config` directory inside the pod.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, you can edit node-problem-detector.yaml to fit your environment. Set log volume to your system log directory (used by SystemLogMonitor). For Kubernetes versions older than 1.9, use node-problem-detector-old.yaml.

  • Create the DaemonSet with kubectl create -f deployment/node-problem-detector.yaml.
  • If needed, you can use a ConfigMap to overwrite the config directory inside the pod.

Copy link
Member

@andyxning andyxning Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-rocket-internet Thanks for updating this. I suggest adding some comma to make the sentences more readable. Please correct me if there are any un-comfortable changes for your. :) English is not my mother language.

I also suggest we keep the items format for create the daemonset and If needed to make the doc more readable. :)

@andyxning
Copy link
Member

@max-rocket-internet Just one nit. Others lgtm.

@max-rocket-internet
Copy link
Contributor Author

Hey @andyxning, I think I've implemented your suggestions, please check 🙂

@andyxning
Copy link
Member

@max-rocket-internet Could you please rebase from the master with the latest change for the Installation section.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2018
@max-rocket-internet
Copy link
Contributor Author

@andyxning I don't really get what you mean. Can you be specific? Edit node-problem-detector.yaml to fit your environment is also repeated twice there. Also there is grammar error environment. and.

Signed-off-by: Max Williams <max.williams@deliveryhero.com>
@max-rocket-internet
Copy link
Contributor Author

I think I understand now. Please re-review @andyxning 🙂

@andyxning
Copy link
Member

/lgtm
/approve

Thanks @max-rocket-internet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, max-rocket-internet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit d49bc17 into kubernetes:master Nov 14, 2018
@max-rocket-internet max-rocket-internet deleted the readme_update branch November 14, 2018 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants