WIP: build cni and kubelet debian packages #35

mikedanese · 2016-07-14T05:03:26Z

To install the kubelet, cni and correct version of docker on Ubuntu 16.04:

$ cat <<EOF > /etc/apt/sources.list.d/k8s.list
deb [arch=amd64] https://apt.dockerproject.org/repo ubuntu-xenial main
deb [arch=amd64] http://ppa.launchpad.net/k8s/ppa/ubuntu xenial main 
EOF
$ apt-key adv --keyserver hkp://keyserver.ubuntu.com --recv-keys F76221572C52609D
$ apt-key adv --keyserver hkp://keyserver.ubuntu.com --recv-keys 738C1654E1DEBDE4
$ apt-get update
$ apt-get install kubelet

@kubernetes/sig-cluster-lifecycle

vishh · 2016-07-14T22:30:25Z

Woot! Will a dependency on docker engine package be added later?

mikedanese · 2016-07-14T23:06:34Z

@vishh already added https://github.com/kubernetes/release/pull/35/files#diff-2ef538a1cb3b8e3e5f44640058d99218R13

mikedanese · 2016-07-14T23:13:56Z

Installing kubelet installs aufs-tools cgroupfs-mount docker-engine k8s-cni kubelet libltdl7. k8s-cni and docker-engine are the direct dependencies.

root@instance-5:/home/mikedanese# apt-get install -y kubelet
The following additional packages will be installed:
  aufs-tools cgroupfs-mount docker-engine k8s-cni libltdl7
Suggested packages:
  mountall
The following NEW packages will be installed:
  aufs-tools cgroupfs-mount docker-engine k8s-cni kubelet libltdl7
0 upgraded, 6 newly installed, 0 to remove and 37 not upgraded.
Need to get 33.9 MB of archives.
After this operation, 229 MB of additional disk space will be used.
Get:1 http://us-central1.gce.archive.ubuntu.com/ubuntu xenial/universe amd64 aufs-tools amd64 1:3.2+20130722-1.1ubuntu1 [92.9 kB]
Get:2 http://us-central1.gce.archive.ubuntu.com/ubuntu xenial/universe amd64 cgroupfs-mount all 1.2 [4,970 B]
Get:3 http://us-central1.gce.archive.ubuntu.com/ubuntu xenial/main amd64 libltdl7 amd64 2.4.6-0.1 [38.3 kB]
Get:4 http://ppa.launchpad.net/k8s/ppa/ubuntu xenial/main amd64 k8s-cni amd64 0.0.1-0 [5,898 kB]
Get:5 https://apt.dockerproject.org/repo ubuntu-xenial/main amd64 docker-engine amd64 1.11.2-0~xenial [14.5 MB]
Get:6 http://ppa.launchpad.net/k8s/ppa/ubuntu xenial/main amd64 kubelet amd64 1.3.0-1 [13.4 MB]
Fetched 33.9 MB in 5s (6,157 kB/s)
Selecting previously unselected package aufs-tools.
(Reading database ... 59822 files and directories currently installed.)
Preparing to unpack .../aufs-tools_1%3a3.2+20130722-1.1ubuntu1_amd64.deb ...
Unpacking aufs-tools (1:3.2+20130722-1.1ubuntu1) ...
Selecting previously unselected package cgroupfs-mount.
Preparing to unpack .../cgroupfs-mount_1.2_all.deb ...
Unpacking cgroupfs-mount (1.2) ...
Selecting previously unselected package libltdl7:amd64.
Preparing to unpack .../libltdl7_2.4.6-0.1_amd64.deb ...
Unpacking libltdl7:amd64 (2.4.6-0.1) ...
Selecting previously unselected package docker-engine.
Preparing to unpack .../docker-engine_1.11.2-0~xenial_amd64.deb ...
Unpacking docker-engine (1.11.2-0~xenial) ...
Selecting previously unselected package k8s-cni.
Preparing to unpack .../k8s-cni_0.0.1-0_amd64.deb ...
Unpacking k8s-cni (0.0.1-0) ...
Selecting previously unselected package kubelet.
Preparing to unpack .../kubelet_1.3.0-1_amd64.deb ...
Unpacking kubelet (1.3.0-1) ...
Processing triggers for libc-bin (2.23-0ubuntu3) ...
Processing triggers for man-db (2.7.5-1) ...
Processing triggers for ureadahead (0.100.0-19) ...
Processing triggers for systemd (229-4ubuntu6) ...
Setting up aufs-tools (1:3.2+20130722-1.1ubuntu1) ...
Setting up cgroupfs-mount (1.2) ...
Setting up libltdl7:amd64 (2.4.6-0.1) ...
Setting up docker-engine (1.11.2-0~xenial) ...
Setting up k8s-cni (0.0.1-0) ...
Setting up kubelet (1.3.0-1) ...
Processing triggers for libc-bin (2.23-0ubuntu3) ...
Processing triggers for systemd (229-4ubuntu6) ...
Processing triggers for ureadahead (0.100.0-19) ...

bgrant0607 · 2016-07-15T00:03:27Z

cc @kubernetes/sig-node @kubernetes/release-maintainers

philips · 2016-07-19T16:20:32Z

debian/kubelet/kubelet.service

+Documentation=https://github.com/kubernetes/kubernetes
+
+[Service]
+ExecStart=/var/lib/kubelet/kubelet-wrapper


probably should go into /usr/share/kubelet/kubelet-wrapper or something.

Or rather /usr/lib/kubelet/, as it's going to be an executable.

philips · 2016-07-19T16:21:01Z

Overall LGTM. I have maintained debs in the past, nothing glaring.

roberthbailey · 2016-07-19T20:33:36Z

@mansoorj wants to make sure this will work on ubuntu (which isn't clear given the pr title).

mikedanese · 2016-07-19T20:37:09Z

This currently only works on ubuntu xenial. I need to expand it to more debian flavors which involves testing an porting systemd to upstart.

luxas · 2016-07-21T09:05:34Z

debian/k8s-cni/99_bridge.conf

@@ -0,0 +1,18 @@
+{
+  "cniVersion": "0.1.0",
+  "name": "kubenet",


Does kubenet only work on GCE?
Is there a convenient way to support other network drivers?

This is not related to the kubelet kubenet plugin, (which doesn't just work on GCE, it works everywhere). This is the "name" field of the bridge cni plugin which represents the name of the network.

https://github.com/containernetworking/cni/blob/master/Documentation/bridge.md

The convenient way to support other cni plugins is add a config file that lexically sorts to a higher slot then 99_bridge.conf, e.g. 10_flannel.conf. Bridge plugin seems like a reasonable default

Great! Then my obvious second question is, why don't we use kubenet in ALL deployments if it works everywhere? :)

No more flannel/weave dep then, unless they provide some really important side effect of course.

Kubenet doesn't actually provide an overlay. We are working on turning it into a cni plugin. It will be a metaplugin that configures the bridge plugin according to the cidrs passed down by the node controller. This is very usful when running in cloud providers that supported routed networks.

Ah, then my assumption was right (that it didn't contain an overlay)

Seems like I misinterpreted your previous comment then (it clearly would have been to good to be true if kubenet did provide an overlay and worked everywhere)

Converting it into a CNI plugin SGTM

mikedanese · 2016-07-25T18:59:58Z

I need to look into doing this like bazel does. They are hosting the apt repository on GCS. https://bazel-review.googlesource.com/#/c/3702/

errordeveloper · 2016-07-26T10:38:02Z

debian/kubelet/kubelet-wrapper

+set -o errexit
+set -o pipefail
+
+source /etc/default/kubelet


I'd expect this to be EnvironmentFile=/etc/default/kubelet in kubelet.service, unless we think that users should be really allowed to do anything shell permits (like loops, conditions and sourcing other files etc)?

By the way, it looks like this file seems to be missing from the package, and this script will fail, unless user has created it.

I think /etc/default files are usually not env files? Is that not true? Lot's of stuff doesn't work in env files, e.g.

DOCKER_OPTS="${DOCKER_OPTS} --dns 8.8.8.8"

Wouldn't work because it requires a bash expansion

mikedanese · 2016-07-29T21:05:25Z

cc @mansoorj @kelseyhightower

mikedanese · 2016-08-16T18:02:42Z

I appreciate your comments and will address in a follow up. I'm currently working on infrastructure to get these hosted on GCS and it will help to have this merged. There are definitely improvements to be made to the actual package.

mikedanese · 2016-08-17T02:57:45Z

Now hosted on gcs

$ cat <<EOF > /etc/apt/sources.list.d/k8s.list
deb [arch=amd64] http://apt.dockerproject.org/repo ubuntu-xenial main
deb http://apt.k8s.io xenial main 
EOF
$ apt-key adv --keyserver hkp://keyserver.ubuntu.com --recv-keys F76221572C52609D 81A45CB679084BD1
$ apt-get update
$ apt-get install kubelet docker-engine=1.11.2-0~xenial

Unfortunately requires version pinning of docker so upgrades might be hard.

lukemarsden · 2016-08-22T16:43:40Z

Probably harmless but minor annoyance after apt-get update:

N: Skipping acquire of configured file 'main/binary-i386/Packages' as repository 'http://apt.k8s.io xenial InRelease' doesn't support architecture 'i386'

luxas · 2016-08-22T19:59:52Z

@lukemarsden I guess we have to put deb [arch=amd64] http://apt.k8s.io xenial main instead of deb http://apt.k8s.io xenial main

* Add support for ppc64, arm64, s390x Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com> * add make to aarch64 dockerfile Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>

Flesh out CI Signal responsibilities during code freeze

googlebot added the cla: yes label Jul 14, 2016

build cni and kubelet debian packages

7f44568

mikedanese force-pushed the deb branch from 49b5598 to 7f44568 Compare July 14, 2016 05:28

philips reviewed Jul 19, 2016
View reviewed changes

luxas reviewed Jul 21, 2016
View reviewed changes

errordeveloper reviewed Jul 26, 2016
View reviewed changes

david-mcmahon mentioned this pull request Aug 3, 2016

Investigate using snap packages #44

Closed

Random-Liu mentioned this pull request Aug 5, 2016

Node Conformance Test Planning kubernetes/kubernetes#30122

Closed

8 tasks

dgoodwin mentioned this pull request Aug 8, 2016

WIP: Add kubelet RPM package builds. #50

Merged

lukemarsden mentioned this pull request Aug 11, 2016

Proposal: Dramatically Simplify Kubernetes Cluster Creation kubernetes/kubernetes#30360

Closed

mikedanese merged commit 1cf85d0 into kubernetes:master Aug 16, 2016

mikedanese deleted the deb branch August 16, 2016 18:02

marpaia pushed a commit to marpaia/release that referenced this pull request Feb 21, 2019

Merge pull request kubernetes#35 from spiffxp/looking-at-more-dashboards

165bcc0

Flesh out CI Signal responsibilities during code freeze

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: build cni and kubelet debian packages #35

WIP: build cni and kubelet debian packages #35

mikedanese commented Jul 14, 2016 •

edited

Loading

vishh commented Jul 14, 2016

mikedanese commented Jul 14, 2016

mikedanese commented Jul 14, 2016

bgrant0607 commented Jul 15, 2016

philips Jul 19, 2016

errordeveloper Jul 26, 2016 •

edited

Loading

philips commented Jul 19, 2016

roberthbailey commented Jul 19, 2016

mikedanese commented Jul 19, 2016

luxas Jul 21, 2016

mikedanese Jul 21, 2016

luxas Jul 22, 2016

mikedanese Jul 22, 2016

luxas Jul 22, 2016

mikedanese commented Jul 25, 2016

errordeveloper Jul 26, 2016 •

edited

Loading

errordeveloper Jul 26, 2016

mikedanese Aug 16, 2016

mikedanese commented Jul 29, 2016

mikedanese commented Aug 16, 2016

mikedanese commented Aug 17, 2016 •

edited

Loading

lukemarsden commented Aug 22, 2016

luxas commented Aug 22, 2016

WIP: build cni and kubelet debian packages #35

WIP: build cni and kubelet debian packages #35

Conversation

mikedanese commented Jul 14, 2016 • edited Loading

vishh commented Jul 14, 2016

mikedanese commented Jul 14, 2016

mikedanese commented Jul 14, 2016

bgrant0607 commented Jul 15, 2016

Choose a reason for hiding this comment

errordeveloper Jul 26, 2016 • edited Loading

Choose a reason for hiding this comment

philips commented Jul 19, 2016

roberthbailey commented Jul 19, 2016

mikedanese commented Jul 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikedanese commented Jul 25, 2016

errordeveloper Jul 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikedanese commented Jul 29, 2016

mikedanese commented Aug 16, 2016

mikedanese commented Aug 17, 2016 • edited Loading

lukemarsden commented Aug 22, 2016

luxas commented Aug 22, 2016

mikedanese commented Jul 14, 2016 •

edited

Loading

errordeveloper Jul 26, 2016 •

edited

Loading

errordeveloper Jul 26, 2016 •

edited

Loading

mikedanese commented Aug 17, 2016 •

edited

Loading