Skip to content

Conversation

@4rivappa
Copy link
Contributor

@4rivappa 4rivappa commented Aug 29, 2025

Description

Add debug logs of python script to stderr, so that we can output details of failed parsing cve title to debug later.

Changes Made

  • Update python script to output debug logs about parsing failed issue titles (along with urls).
  • Update controller shell script to handle the above debug output.

Testing

  • Tested changes locally, with possible scenarios.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 29, 2025
@tabbysable
Copy link
Member

oooh, thank you!

Please rebase this on top of Mahe's testing diff

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2025
Signed-off-by: arivappa <4rivappa@proton.me>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2025
Signed-off-by: arivappa <4rivappa@proton.me>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2025
@4rivappa 4rivappa requested a review from mtardy September 6, 2025 13:58
@mtardy
Copy link
Member

mtardy commented Sep 13, 2025

/label tide/merge-method-squash
/retest

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 13, 2025
@mtardy
Copy link
Member

mtardy commented Sep 13, 2025

Thank you!! And our tests finally work :D

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 4rivappa, mtardy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8fe70ef into kubernetes:main Sep 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants