Upgrade to blang/semver/v4 v4.0.0

[skitt]

This is the first version to be fully go-mod-compatible.

Signed-off-by: Stephen Kitt skitt@redhat.com

[k8s-ci-robot]

Welcome @skitt!

It looks like this is your first PR to kubernetes/system-validators 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/system-validators has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @skitt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

Looks like it is only used in the package validator. I think kubeadm is not running the package checks at least.

Are you using this library and saw a problem due to the semver library not being at v4?

[skitt]

Looks like it is only used in the package validator. I think kubeadm is not running the package checks at least.

Are you using this library and saw a problem due to the semver library not being at v4?

Not directly; this is for consistency with kubernetes/kubernetes#108629, to clean up the dependency tree of dependencies further down from Kubernetes (where we end up with both version 3.5.1 and 4.0.0 of semver).

[neolit123]

/ok-to-test

Ok that is fair, given k/k is the main user but this lib will have to be bumped with a new release and revendored in k/k.

There is already one MINOR level feature pending release. Releases of this lib happen close before code freeze of a k/k release (pending).

If there was nothing else commited we could have made a patch level bump with the semver bump.

[neolit123]

/lgtm
/approve

i should keep a note to release a new version of this repository before the 30th of march (code freeze for k8s 1.24).

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[skitt]

i should keep a note to release a new version of this repository before the 30th of march (code freeze for k8s 1.24).

Gentle reminder about this so there’s time to merge the bump in k/k itself...

[neolit123]

had a todo for next week, but i guess i can push the release today.
don't think anything new will land here before the k8s CF.

[skitt]

Thanks!