Skip to content

Cherry-Pick cgroup check fix #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2024
Merged

Cherry-Pick cgroup check fix #44

merged 3 commits into from
Nov 4, 2024
+61 −30

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Nov 4, 2024

#43

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot requested a review from odinuge November 4, 2024 10:02
@pacoxu
Copy link
Member Author

pacoxu commented Nov 4, 2024

/cc @neolit123

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2024
@neolit123
Copy link
Member

#43 merged in main
we need a PR for release-1.9

github UI says this PR is also for main.

@pacoxu pacoxu changed the base branch from main to release-1.9 November 4, 2024 10:42
@pacoxu
Copy link
Member Author

pacoxu commented Nov 4, 2024

#43 merged in main we need a PR for release-1.9

github UI says this PR is also for main.

Updated.

neolit123
neolit123 reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit ae0e5f8 into kubernetes:release-1.9 Nov 4, 2024
3 checks passed
@bzsuni bzsuni mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neolit123 neolit123 neolit123 left review comments

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@neolit123 neolit123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pacoxu @neolit123 @k8s-ci-robot