-
Notifications
You must be signed in to change notification settings - Fork 30
Use unix.Uname
instead of exec'ing uname
#46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @tklauser. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is fine, just trying to understand the reason for the change.
/cc @pacoxu
/ok-to-test |
Instead of execing the uname(1) command, use the uname(2) syscall directly by means of the unix.Uname wrapper function to get the kernel release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
this code will be included in the next release of the lib.
thanks @tklauser
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, tklauser The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Instead of execing the
uname(1)
command, use theuname(2)
syscall directly by means of theunix.Uname
wrapper function to get the kernel release.