Skip to content

Update ci dependencies #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

Update ci dependencies #278

merged 2 commits into from
Mar 8, 2023
+36 −31

Conversation

@aojea
Copy link
Member

@aojea aojea commented Mar 8, 2023

Remove golang 1.18 and add golang 1.20
Bump golangci-lint to 1.51.2

/kind cleanup

NONE

@aojea
Update ci dependencies
4c1fdf9 
Remove golang 1.18 and add golang 1.20
Bump golangci-lint to 1.51.2
@aojea
Copy link
Member Author

aojea commented Mar 8, 2023

/assign @thockin @dims

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2023
@dims
Copy link
Member

dims commented Mar 8, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot requested review from lavalamp and mcrute March 8, 2023 15:44
aojea
aojea commented Mar 8, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2023
@aojea
Copy link
Member Author

aojea commented Mar 8, 2023

@dims fixed now, was the gofmt change on comments,

@dims
Copy link
Member

dims commented Mar 8, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d77c459 into kubernetes:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@mcrute mcrute Awaiting requested review from mcrute

Assignees

@dims dims

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aojea @dims @k8s-ci-robot @thockin