Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerize generating k8s reference documentation script #28037

Open
PI-Victor opened this issue May 18, 2021 · 24 comments
Open

containerize generating k8s reference documentation script #28037

PI-Victor opened this issue May 18, 2021 · 24 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@PI-Victor
Copy link
Member

PI-Victor commented May 18, 2021

The update-imported-docs.py that is used to generate the kubernetes documentation reference should be containerized to make it easier for users that want to update the ref docs.
This container should include all the tooling mentioned in the quickstart.

Q: OS Linux flavor preferences for the container?
Q: Locally buildable Dockerfile or push an already created image to hub.docker.com/quay.io?
Q: Anything else worth mentioning that i've missed

cc @sftim @reylejano @jimangel @irvifa

/assign
/priority important-soon - targeting this change before 1.22 release

@PI-Victor PI-Victor added the kind/feature Categorizes issue or PR as related to a new feature. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

@PI-Victor: The label(s) priority/-, priority/targeting, priority/this, priority/change, priority/before, priority/1.22, priority/release cannot be applied, because the repository doesn't have them.

In response to this:

The update-imported-docs.py that is used to generate the kubernetes documentation reference should be containerized to make it easier for users that want to update the docs.
This container should include all the tooling mentioned in the quickstart.

Q: OS preferences for the container?
Q: Locally buildable Dockerfile or push an already created image to hub.docker.com/quay.io?
Q: Anything else worth mentioning that i've missed

cc @sftim @reylejano @jimangel @irvifa

/assign
/priority important-soon - targeting this change before 1.22 release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 18, 2021
@sftim
Copy link
Contributor

sftim commented May 19, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 19, 2021
@sftim
Copy link
Contributor

sftim commented May 19, 2021

OS preferences for the container?

Linux 😉

@sftim
Copy link
Contributor

sftim commented May 20, 2021

/area release-engineering

@k8s-ci-robot
Copy link
Contributor

@sftim: The label(s) area/release-engineering cannot be applied, because the repository doesn't have them.

In response to this:

/area release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented May 20, 2021

/area release-engineering

@k8s-ci-robot
Copy link
Contributor

@sftim: The label(s) area/release-engineering cannot be applied, because the repository doesn't have them.

In response to this:

/area release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PI-Victor
Copy link
Member Author

/area release-eng

found it!
also, i should've said: linux flavor preferences for the container?

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label May 20, 2021
@sftim
Copy link
Contributor

sftim commented May 20, 2021

linux flavor preferences for the container

No preference from me.

@sftim
Copy link
Contributor

sftim commented Aug 1, 2021

As we've missed this for v1.22
/remove-priority important-soon
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 1, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 29, 2021
@PI-Victor
Copy link
Member Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 1, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 1, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 31, 2022
@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 31, 2022
@sftim
Copy link
Contributor

sftim commented Mar 31, 2022

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 31, 2022
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 31, 2023
@Gauravpadam
Copy link
Member

Is this issue still relevant? I'd like to help

@sftim
Copy link
Contributor

sftim commented Nov 7, 2023

Is this issue still relevant? I'd like to help

Help in this will be very much appreciated @Gauravpadam

@sftim
Copy link
Contributor

sftim commented Nov 7, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2023
@Gauravpadam
Copy link
Member

Gauravpadam commented Nov 7, 2023

@sftim I see some errors on testing the script for release 1.28, Most of them pertaining to release directories not found

While this should not affect our dockerfile, I'd like to know your thoughts on them

- 'make generated_files' is deprecated.  Please use hack/update-codegen.sh instead.
make: *** [Makefile:319: generated_files] Error 1

- cp: cannot stat '/tmp/tmpx1g2t821/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/v1_27/*': No such file or directory

- 2023/11/07 21:43:49 Failed to generate files: failed to read TOC file generators/v1_28/toc.yaml: open generators/v1_28/toc.yaml: no such file or directory

- mkdir -p /home/gp/website/static/docs/reference/generated/kubernetes-api/v1.28/js
  cp gen-apidocs/build/navData.js /home/gp/website/static/docs/reference/generated/kubernetes-api/v1.28/js/
  cp: cannot stat 'gen-apidocs/build/navData.js': No such file or directory
  make: *** [Makefile:91: copyapi] Error 1
  [Error] failed in generating docs for reference-docs

@sftim
Copy link
Contributor

sftim commented Nov 8, 2023

I don't have much experience generating this documentation, so I don't really have an opinion here @Gauravpadam.

We should aim to define a container image and a way to run it so that you get the documentation generated.

@Gauravpadam
Copy link
Member

No worries @sftim, I'll figure it out eventually

@Gauravpadam
Copy link
Member

Gauravpadam commented Dec 5, 2023

Should I just host the image on a public repository?

(I'm mentioning the build steps currently)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Triage Accepted
Development

Successfully merging a pull request may close this issue.

5 participants