Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure file feature gates for 1.21 beta #26818

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Update Azure file feature gates for 1.21 beta #26818

merged 3 commits into from
Mar 18, 2021

Conversation

andyzhangx
Copy link
Member

Docs for kubernetes/enhancements#1885

/assign @msau42

/sig storage

@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 3, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 3, 2021 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit b1ed216

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6051a9f7d099900007f5f62a

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2021
@andyzhangx andyzhangx mentioned this pull request Mar 3, 2021
Closed
@reylejano
Copy link
Member

/assign @tengqm

@Jiawei0227
Copy link
Contributor

Can we also include kubernetes/kubernetes#96293 (comment) what is discussed here for the unsupported feature?

Just like what vSphere did here: https://kubernetes.io/docs/concepts/storage/volumes/#vsphere-csi-migration

tengqm
tengqm reviewed Mar 4, 2021
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -74,7 +74,8 @@ different Kubernetes components.
| `CSIMigrationAzureDisk` | `false` | Alpha | 1.15 | 1.18 |
| `CSIMigrationAzureDisk` | `false` | Beta | 1.19 | |
| `CSIMigrationAzureDiskComplete` | `false` | Alpha | 1.17 | |
| `CSIMigrationAzureFile` | `false` | Alpha | 1.15 | |
| `CSIMigrationAzureFile` | `false` | Alpha | 1.15 | 1.19 |
| `CSIMigrationAzureFile` | `false` | Beta | 1.21 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beta feature defaulted to 'False'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no for this case, let's make consistent with k/k PR: kubernetes/kubernetes#96293, thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyzhangx you're saying that it does default to false and that this is correct given the context. Have I got that right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim that's correct, we want to make this feature as beta while still default to false, same for other providers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. The Beta here signals the maturity level of the feature. However, this feature relies on some external components which have to be manually provisioned. Defaulting to 'false' makes sense.

sftim
sftim reviewed Mar 5, 2021
View reviewed changes
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -74,7 +74,8 @@ different Kubernetes components.
| `CSIMigrationAzureDisk` | `false` | Alpha | 1.15 | 1.18 |
| `CSIMigrationAzureDisk` | `false` | Beta | 1.19 | |
| `CSIMigrationAzureDiskComplete` | `false` | Alpha | 1.17 | |
| `CSIMigrationAzureFile` | `false` | Alpha | 1.15 | |
| `CSIMigrationAzureFile` | `false` | Alpha | 1.15 | 1.19 |
| `CSIMigrationAzureFile` | `false` | Beta | 1.21 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyzhangx you're saying that it does default to false and that this is correct given the context. Have I got that right?

@andyzhangx @sftim
Update content/en/docs/concepts/storage/volumes.md
1e77a68 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@msau42
Copy link
Member

msau42 commented Mar 8, 2021

/assign @gnufied
to help review the deprecation notices

@tengqm
Copy link
Contributor

tengqm commented Mar 9, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@gnufied
Copy link
Member

gnufied commented Mar 9, 2021

Before we merge this - please don't forget to address #26818 (comment)

@kbhawkey
Copy link
Contributor

👋 @andyzhangx .
Have you addressed this comment:

Can we also include kubernetes/kubernetes#96293 (comment) what is discussed here for the unsupported feature?

Just like what vSphere did here: https://kubernetes.io/docs/concepts/storage/volumes/#vsphere-csi-migration

@andyzhangx
Copy link
Member Author

andyzhangx commented Mar 17, 2021 •
edited
Loading

Before we merge this - please don't forget to address #26818 (comment)

@gnufied thanks for reminder, added one notes in the PR:

Azure File CSI driver does not support using same volume with different fsgroups, if Azurefile CSI migration is enabled, using same volume with different fsgroups won't be supported at all.

@tengqm
Copy link
Contributor

tengqm commented Mar 18, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 184eb044405d22cf6aa8a59791371e40bf25ceff

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7afd404 into kubernetes:dev-1.21 Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

@onlydole onlydole Awaiting requested review from onlydole

@thockin thockin Awaiting requested review from thockin

Assignees

@gnufied gnufied

@tengqm tengqm

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
10 participants
@andyzhangx @k8sio-netlify-preview-bot @reylejano @Jiawei0227 @msau42 @tengqm @gnufied @kbhawkey @k8s-ci-robot @sftim