add units for disk size in VM disk page

[atiratree]

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1667828

I also changed units to Gi in VmCreateDialog StorageTab for more consistent UI

[coveralls]

Pull Request Test Coverage Report for Build 851

• 10 of 10 (100.0%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 87.154%

---

Totals
Change from base Build 665:	0.03%
Covered Lines:	2078
Relevant Lines:	2279

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 674

• 10 of 10 (100.0%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 87.154%

---

Totals
Change from base Build 665:	0.03%
Covered Lines:	2078
Relevant Lines:	2279

---

💛 - Coveralls

[andybraren]

I don't have an easy way of checking at the moment, but I believe the rest of OKD's UI includes the "B" in MiB/GiB/TiB, even though the YAML uses the shorthand Mi/Gi/Ti. Should we change to that for consistency? I think they also include a space between the number value and unit label: "4 GiB".

[atiratree]

I think they also include a space between the number value and unit label: "4 GiB".

there is 1Gi in pvc detail for example.

We are also showing the Gi shorthand in the disks table as seen in the picture.
The consistency is the way to go, but I don't know what is better solution. IMO shorthands are better, because they are the native k8s format.

[rawagner]

Gi in PVC detail but GiB in new PVC form. So tectonic itself has inconsistencies. Also they do not add space between number and unit (based on PVC detail)

[atiratree]

@andybraren maybe you can bring up the issue somewhere higher to get the whole UI consistent?

[andybraren]

I was wrong - using 4Gi without a space is okay for the reasons you both noted. I agree this is something we need to figure out at a higher level, but since shorthand is the native k8s format that's a strong reason to use this format (even though it will look even less familiar to virtualization users expecting to see GB/TB).

Weirdly, clicking the unit dropdown in the Add PVC form changes GiB to shorthand units. A bug?

[atiratree]

seems like it, nevertheless this should go to https://github.com/openshift/console